SW-15412 - Merge config and base combobox and ensure usage of unique store instance

This commits improves the base combo box `Shopware.apps.Config.view.element.Select`, which is used e.g. when viewing plugin configuration forms via the settings module, to allow passing a store ID as the `store` parameter. This is escpecially usefull when providing selections of e.g. payment methods (`Shopware.apps.Base.store.Payment`) or dispatch methods (`Shopware.apps.Base.store.Dispatch`). In order to avoid side effects of other backend modules using the same store instance (and e.g. setting filters on it), the combo box does not use the instance that is registered by the passed store ID, but creates and uses a new instance of that store instead.

See also PR #525 for the original change of the `base` combo box, which is used when viewing plugin config forms in the plugin manager. This commit fixes the viewing of the same plugin config forms in the settings module. Furthermore it already includes the latest fix to support old storeIDs (22f5cac).

This commit does not introduce any breaking changes.

Author: janbuecker

UPGRADE.md

@@ -398,7 +398,7 @@ In this document you will find a changelog of the important changes related to t
     * `\Shopware\Bundle\StoreFrontBundle\Struct\ProductContext`
     * `\Shopware\Bundle\StoreFrontBundle\Struct\LocationContextInterface`
     * `\Shopware\Bundle\StoreFrontBundle\Struct\ProductContextInterface`
-
+* Added support for loading a new store instance by ID in the config combo box `Shopware.apps.Config.view.element.Select`
 
 ## 5.1.6
 * The interface `Enlight_Components_Cron_Adapter` in `engine/Library/Enlight/Components/Cron/Adapter.php` got a new method `getJobByAction`. For default implementation see `engine/Library/Enlight/Components/Cron/Adapter/DBAL.php`.

themes/Backend/ExtJs/backend/config/view/element/select.js

@@ -19,13 +19,15 @@
  * The licensing of the program under the AGPLv3 does not imply a
  * trademark license. Therefore any rights, title and interest in
  * our trademarks remain entirely with us.
- */
-
-/**
- * todo@all: Documentation
+ *
+ * @category   Shopware
+ * @package    Config
+ * @subpackage Component
+ * @version    $Id$
+ * @author shopware AG
  */
 Ext.define('Shopware.apps.Config.view.element.Select', {
-    extend:'Ext.form.field.ComboBox',
+    extend:'Shopware.apps.Base.view.element.Select',
     alias:[
         'widget.config-element-select',
         'widget.config-element-combo',
@@ -34,56 +36,11 @@ Ext.define('Shopware.apps.Config.view.element.Select', {
     ],
 
     queryMode:'remote',
-    forceSelection: false,
-    editable: true,
-    valueField: 'id',
-    displayField: 'name',
 
     initComponent:function () {
         var me = this;
 
-        if (me.controller && me.action) {
-            //me.value = parseInt(me.value);
-            me.store = new Ext.data.Store({
-                url:'{url controller=index}/' + me.controller + '/' + me.action,
-                autoLoad:true,
-                reader:new Ext.data.JsonReader({
-                    root:me.root || 'data',
-                    totalProperty:me.count || 'total',
-                    fields:me.fields
-                })
-            });
-            // Remove value field for reasons of compatibility
-            me.valueField = me.displayField;
-        }
-        // Eval the store string if it contains a statement.
-        if (typeof(me.store) == 'string' && me.store.indexOf('new ') !== -1) {
-            //me.value = parseInt(me.value);
-            eval('me.store = ' + me.store + ';');
-            // Remove value field for reasons of compatibility
-            me.valueField = me.displayField;
-        }
-
         me.callParent(arguments);
         me.queryCaching = (me.store.$className == 'Ext.data.ArrayStore');
-    },
-
-    setValue:function (value) {
-        var me = this;
-
-        if (value !== null && !me.store.loading && me.store.getCount() == 0) {
-            me.store.load({
-                callback:function () {
-                    if(me.store.getCount() > 0) {
-                        me.setValue(value);
-                    } else {
-                        me.setValue(null);
-                    }
-                }
-            });
-            return;
-        }
-
-        me.callParent(arguments);
     }
 });