feat: add ForbidGlobBraceRule with tests

Author: shyim

rules.neon

@@ -7,6 +7,7 @@ rules:
     - Shopware\PhpStan\Rule\MethodBecomesAbstractRule
     - Shopware\PhpStan\Rule\ScheduledTaskTooLowIntervalRule
     - Shopware\PhpStan\Rule\InternalClassExtendsRule
+    - Shopware\PhpStan\Rule\ForbidGlobBraceRule
 
 services:
     -

src/Rule/ForbidGlobBraceRule.php

@@ -0,0 +1,37 @@
+<?php
+
+namespace Shopware\PhpStan\Rule;
+
+use PhpParser\Node;
+use PhpParser\Node\Expr\ConstFetch;
+use PHPStan\Analyser\Scope;
+use PHPStan\Rules\Rule;
+use PHPStan\Rules\RuleErrorBuilder;
+
+/**
+ * @implements Rule<ConstFetch>
+ */
+final class ForbidGlobBraceRule implements Rule
+{
+    public const ERROR_IDENTIFIER = 'shopware.forbidGlobBrace';
+
+    public function getNodeType(): string
+    {
+        return ConstFetch::class;
+    }
+
+    public function processNode(Node $node, Scope $scope): array
+    {
+        if ($node->name->toString() === 'GLOB_BRACE') {
+            return [
+                RuleErrorBuilder::message(
+                    'Usage of GLOB_BRACE constant is forbidden. GLOB_BRACE is not supported on any platform.',
+                )
+                    ->identifier(self::ERROR_IDENTIFIER)
+                    ->build(),
+            ];
+        }
+
+        return [];
+    }
+}

tests/Rule/ForbidGlobBraceRuleTest.php

@@ -0,0 +1,32 @@
+<?php
+
+namespace Shopware\PhpStan\Tests\Rule;
+
+use PHPStan\Testing\RuleTestCase;
+use PHPStan\Rules\Rule;
+use Shopware\PhpStan\Rule\ForbidGlobBraceRule;
+
+/**
+ * @extends RuleTestCase<ForbidGlobBraceRule>
+ */
+final class ForbidGlobBraceRuleTest extends RuleTestCase
+{
+    protected function getRule(): Rule
+    {
+        return new ForbidGlobBraceRule();
+    }
+
+    public function testRule(): void
+    {
+        $this->analyse([__DIR__ . '/../data/ForbidGlobBraceRule/glob.php'], [
+            [
+                'Usage of GLOB_BRACE constant is forbidden. GLOB_BRACE is not supported on any platform.',
+                3,
+            ],
+            [
+                'Usage of GLOB_BRACE constant is forbidden. GLOB_BRACE is not supported on any platform.',
+                6,
+            ],
+        ]);
+    }
+}

tests/data/ForbidGlobBraceRule/glob.php

@@ -0,0 +1,6 @@
+<?php
+
+$files = glob('*.{jpg,jpeg,png}', GLOB_BRACE);
+
+// Should also detect when used with other constants
+$files = glob('*.{jpg,jpeg,png}', GLOB_BRACE | GLOB_NOSORT);