Skip to content

Commit db83f77

Browse files
committed
Revert "ci(shorebird): drop --offline from aot-tools pub get" (#148)
Restores the legacy `pub get --offline` form. The original failure (missing very_good_analysis in shard pub cache) was a shard-environment problem — sync.yaml ran tools/run_pub_get.py to populate the cache, but shards' pub cache is per-runner ephemeral. Fixed properly in shorebirdtech/_build_engine#209 (shard-build.yaml now also runs run_pub_get.py post-sync), so shell steps can rely on --offline matching legacy behavior. The JSON config shouldn't carry the env-prep detail. (See FIXME in build_engine's shard-build.yaml: real fix is to pull aot_tools deps via gclient like every other in-tree Dart package.)
1 parent d66c50b commit db83f77

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

shorebird/ci/shards/linux.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@
9494
},
9595
{
9696
"type": "shell",
97-
"command": "mkdir -p out/host_release/aot_tools && out/host_release/dart-sdk/bin/dart pub get --directory=flutter/third_party/dart/pkg/aot_tools && out/host_release/dart-sdk/bin/dart compile kernel flutter/third_party/dart/pkg/aot_tools/bin/aot_tools.dart -o out/host_release/aot_tools/aot-tools.dill"
97+
"command": "mkdir -p out/host_release/aot_tools && out/host_release/dart-sdk/bin/dart pub get --offline --directory=flutter/third_party/dart/pkg/aot_tools && out/host_release/dart-sdk/bin/dart compile kernel flutter/third_party/dart/pkg/aot_tools/bin/aot_tools.dart -o out/host_release/aot_tools/aot-tools.dill"
9898
}
9999
],
100100
"artifacts": [

0 commit comments

Comments
 (0)