Skip to content

Commit ff330bc

Browse files
committed
fix: update updater cbindgen toml inputs after upstream API split
Upstream commit be89e40 (#138) split the updater C API into separate engine and dart cbindgen configs (cbindgen_engine.toml / cbindgen_dart.toml) and removed the combined cbindgen.toml, but the companion shell/common/shorebird/BUILD.gn change to update the declared inputs was not landed. Without this fix, the iOS engine build fails with: ninja: error: '../../flutter/third_party/updater/library/cbindgen.toml', needed by 'gen/flutter/shell/common/shorebird/rust_updater_<...>.stamp', missing and no known rule to make it Worth landing upstream as a follow-up on #138.
1 parent 6f4f270 commit ff330bc

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

  • engine/src/flutter/shell/common/shorebird

engine/src/flutter/shell/common/shorebird/BUILD.gn

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,8 @@ if (shorebird_updater_supported) {
8686
"$shorebird_updater_dir/Cargo.lock",
8787
"$shorebird_updater_dir/library/Cargo.toml",
8888
"$shorebird_updater_dir/library/build.rs",
89-
"$shorebird_updater_dir/library/cbindgen.toml",
89+
"$shorebird_updater_dir/library/cbindgen_dart.toml",
90+
"$shorebird_updater_dir/library/cbindgen_engine.toml",
9091
"$shorebird_updater_dir/library/.cargo/config.toml",
9192
]
9293
inputs += shorebird_updater_rs_sources

0 commit comments

Comments
 (0)