Remove AMYboard patch-file support

Patch files (.patch wire-command dumps) are no longer used. Removes:

- amyboard.py: load_patch_file(), save_patch_file() (the last caller of
  amy.get_synth_commands() in tulipcc), and the PatchSelector encoder app
- spss.js: dead num_oscs_from_patch_file_content() and
  write_channel_dirty_patch_file() helpers, stale comments referencing
  restore_patch_state_from_files
- server: patch_selector/PatchSelector from the display/encoder
  hardware-tag regexes and the matching test_hardware_tags check
- docs: patch_selector() mention and example in accessories.md

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Author: bwhitman

docs/amyboard/accessories.md

@@ -120,7 +120,7 @@ amyboard.monitor_encoders()
 ```
 
  - ![Adafruit QT Quad Rotary Encoder](img/accessory_adafruit_quad_encoder.jpg)  
-   [**Adafruit I2C QT Quad Rotary Encoder Breakout**](https://www.adafruit.com/product/5752) -- Four rotary encoders with built-in push buttons and one RGB NeoPixel per encoder on a single I2C breakout, running seesaw firmware. AMYboard has built-in support via `read_encoder()`, `init_buttons()`, `read_buttons()`, and `init_neopixels()`/`set_neopixel()`/`show_neopixels()`. With a display connected, you can use `patch_selector()` to scroll through your `.patch` files with one encoder and load them with a click.
+   [**Adafruit I2C QT Quad Rotary Encoder Breakout**](https://www.adafruit.com/product/5752) -- Four rotary encoders with built-in push buttons and one RGB NeoPixel per encoder on a single I2C breakout, running seesaw firmware. AMYboard has built-in support via `read_encoder()`, `init_buttons()`, `read_buttons()`, and `init_neopixels()`/`set_neopixel()`/`show_neopixels()`.
 
 ```python
 import amyboard
@@ -141,11 +141,6 @@ amyboard.set_neopixel(1, 0, 64, 0)   # encoder 1 -> dim green
 amyboard.set_neopixel(2, 0, 0, 64)   # encoder 2 -> dim blue
 amyboard.set_neopixel(3, 32, 32, 0)  # encoder 3 -> dim yellow
 amyboard.show_neopixels()            # latch staged colors to the LEDs
-
-# Patch selector: scroll through patches and load on click
-# (requires a display to be connected)
-amyboard.init_display()
-amyboard.patch_selector()
 ```
 
  - ![M5Stack 8-Encoder Unit](img/accessory_m5_8encoder.jpg)  

tulip/amyboardweb/static/spss.js

@@ -762,19 +762,6 @@ function remove_current_environment_file_if_exists(filename) {
   return false;
 }
 
-function num_oscs_from_patch_file_content(source) {
-  var maxOsc = -1;
-  var lines = String(source || "").split(/\r?\n/);
-  for (var i = 0; i < lines.length; i++) {
-    var m = lines[i].match(/^v(\d+)/);
-    if (m) {
-      var osc = parseInt(m[1], 10);
-      if (osc > maxOsc) maxOsc = osc;
-    }
-  }
-  return maxOsc < 0 ? 3 : maxOsc + 1;
-}
-
 function get_wire_commands_for_juno_patch(patch) {
   // The new convention for AMYboard voice osc usage.
   const CTL_OSC = 0;  // Osc with filter & env commands.
@@ -1053,8 +1040,6 @@ function get_wire_commands_for_channel(channel) {
   return lines;
 }
 
-function write_channel_dirty_patch_file(channel) { /* no-op */ }
-
 const pending_channel_knob_sync = new Array(17).fill(false);
 
 function schedule_channel_knob_sync_after_ui_ready(channel) {
@@ -6200,9 +6185,9 @@ async function start_audio() {
       await amy_live_start_web();
   }
   // Allow a few audio callbacks to fire so amy_execute_deltas processes
-  // any wire commands that were queued before audio started (e.g. from
-  // restore_patch_state_from_files during boot).  Without this delay,
-  // yield_synth_commands would read stale default values for global effects.
+  // any wire commands that were queued before audio started.  Without this
+  // delay, yield_synth_commands would read stale default values for global
+  // effects.
   await new Promise(function(resolve) { setTimeout(resolve, 150); });
   // Set up AnalyserNode to capture output waveform for Python
   try {
@@ -6235,8 +6220,8 @@ async function start_audio() {
   // to race a default run_sketch() against check_url_env_params's deferred load.
   if (mp && !_url_env_pending) {
     // Init synth 1 with default Juno patch before run_sketch applies knobs.
-    // On main, restore_patch_state_from_files did this. Without it, synth 1
-    // doesn't exist and _apply_knobs_text fails with "synth not defined".
+    // Without it, synth 1 doesn't exist and _apply_knobs_text fails with
+    // "synth not defined".
     amy_add_message("i1K257iv6Z");
     // Let AMY process the synth init before running Python.
     await new Promise(function(resolve) { setTimeout(resolve, 100); });

tulip/server/amyboardworld_db_api.py

@@ -1581,14 +1581,14 @@ def _unique_generator_filename(base: str, gen_id: int) -> str:
 _HW_DISPLAY_RE = re.compile(
     r"\binit_display\s*\(|\bdisplay_refresh\s*\("
     r"|\bdisplay\s*\.\s*(?:text|fill|fill_rect|rect|line|hline|vline|pixel|scroll|show|refresh|clear|message)\b"
-    r"|\bmonitor_encoders\s*\(|\bdraw_waveform\s*\(|\bshow_midi_ccs\s*\(|\bpatch_selector\s*\(|\bPatchSelector\s*\("
+    r"|\bmonitor_encoders\s*\(|\bdraw_waveform\s*\(|\bshow_midi_ccs\s*\("
 )
 # Any rotary-encoder accessory: the unified amyboard.encoder() API, the legacy
 # seesaw helpers, the legacy m5_8encoder module, and the helpers built on them.
 _HW_ENCODER_RE = re.compile(
     r"\bencoder\s*\(|\bamyboard\s*\.\s*Encoder\s*\(|\bread_encoder\s*\(|\bread_buttons\s*\(|\binit_buttons\s*\("
     r"|\bset_neopixel\s*\(|\binit_neopixels\s*\(|\bshow_neopixels\s*\(|\bm5_8encoder\b"
-    r"|\bmonitor_encoders\s*\(|\bpatch_selector\s*\(|\bPatchSelector\s*\("
+    r"|\bmonitor_encoders\s*\("
 )
 # Evidence a sketch is written for the 8-encoder unit specifically: the legacy
 # module, forcing type="m5stack", the m5stack-only toggle switch, touching an

tulip/server/test_hardware_tags.py

@@ -71,7 +71,6 @@ def tags(code: str) -> list[str]:
 
 # --- combinations ---
 check("display + encoder", tags("import amyboard\namyboard.init_display()\nenc = amyboard.encoder()\ndef loop():\n    amyboard.display.text(str(enc.read(0)),0,0,255)\n    amyboard.display.show()") == ["display", "encoder"])
-check("patch_selector implies display + encoder", tags("import amyboard\namyboard.patch_selector()\ndef loop():\n    pass") == ["display", "encoder"])
 
 # --- against the bundled example sketches ---
 SKETCHES = Path(__file__).resolve().parents[1] / "amyboardweb" / "sketches"

tulip/shared/amyboard-py/amyboard.py

@@ -257,46 +257,6 @@ def _clear_directory(path):
         _remove_tree(path.rstrip("/") + "/" + name)
 
 
-def load_patch_file(filename, synth=1, num_voices=6):
-    """Load a .patch file (list of AMY wire commands) into a given synth."""
-
-    def _num_oscs_for_patch(patch):
-        """Scan for how many oscs are used in a patch."""
-        top_osc = 0
-        for line in patch.split('\n'):
-            if not line:
-                continue
-            if line[0] == 'v':
-                osc_num = int(line[1])  # Cannot see osc nums > 9.
-            if osc_num > top_osc:
-                top_osc = osc_num
-        return top_osc + 1
-
-    try:
-        with open(filename, 'rb') as f:
-            patch = f.read().decode('latin-1')
-    except OSError:
-        print("error reading", filename)
-        return
-
-    # Reset global FX.
-    amy.send_raw("V1x0,0,0M0,500,,0,0k0,320,0.5,0.5h0,0.85,0.5,3000")
-    # Reset the synth.
-    oscs_per_voice = _num_oscs_for_patch(patch)
-    amy.send_raw('i%div%din%d' % (synth, num_voices, oscs_per_voice))
-    # Execute the patch.
-    for line in patch.split('\n'):
-        if line and not line.startswith('#'):
-            amy.send_raw('i%d%s' % (synth, line))
-
-
-def save_patch_file(filename, synth=1):
-    """Write the current state of a synth out to a patch file."""
-    patch_commands = amy.get_synth_commands(synth)
-    with open(filename, 'w') as f:
-        f.write(patch_commands)
-
-
 def ensure_user_environment():
     import os
     user_base = tulip.root_dir() + "user"
@@ -1442,152 +1402,3 @@ def draw_waveform():
         last_y = y
     display.show()
 
-
-# Patch Selector -
-# If you have a display and a rotary encoder on I2C
-# this function will let you scroll through your available patches
-# and load each one by clicking the rotary encoder.
-#
-# You can launch it from sketch.py like this:
-#
-#   import amyboard
-#   amyboard.patch_selector()
-#
-# or, for the 4-knob Adafruit rotary encoder:
-#
-#   amyboard.patch_selector(seesaw_dev=0x49, button_pin=12)
-
-class PatchSelector:
-
-    def __init__(
-            self, synth=1, seesaw_dev=0x36, encoder=0, button_pin=24,
-            patch_dir='/user/current', extension='.patch',
-            hold_max=30, exit_callback=lambda: True
-    ):
-        """Endless loop scrolling through patch files and installing on click.  Long click rewrites the file."""
-        self.new_file_prefix = '* '
-        self.synth = synth
-        self.seesaw_dev = seesaw_dev
-        self.encoder = encoder
-        self.button_pin = button_pin
-        self.patch_dir = patch_dir
-        self.extension = extension
-        self.hold_max = hold_max  # Count before "long press" action in ~ deciseconds
-        self.exit_callback = exit_callback  # Not currently used.
-        # State
-        self.patches = self._list_patches()
-        self.index = 0  # within patches
-        self.button_state = False
-        self.hold_count = 0
-        # Make sure we always start at the top of the list.
-        self.last_encoder_value = 0
-        self.encoder_offset = -self.read_encoder()
-        # Initialize
-        display.clear()
-        display.message("PATCH SELECTOR", 0)
-        if self.patches:
-            display.message(self.patches[0], 2)
-        init_buttons(pins=(self.button_pin,), seesaw_dev=self.seesaw_dev)
-
-    def _list_patches(self):
-        """List of the patch files."""
-        try:
-            patches = [f[:-len(self.extension)] for f in os.listdir(self.patch_dir) if f.endswith(self.extension)]
-        except OSError:
-            patches = []
-        for new_patch_num in range(100):
-            new_patch_name = '~NEW PATCH %02d' % new_patch_num
-            if new_patch_name not in patches:
-                patches.append(self.new_file_prefix + new_patch_name)
-                break
-        return patches
-
-    def patch_name(self, index, remove_star=False):
-        """Return the index'th patch name from the stored list, removing "* " prefix if needed."""
-        name = self.patches[index % len(self.patches)]
-        if remove_star and name and name[:len(self.new_file_prefix)] == self.new_file_prefix:
-            name = name[len(self.new_file_prefix):]
-        return name
-
-    def read_encoder(self):
-        value = self.last_encoder_value
-        try:
-            value = read_encoder(self.encoder, seesaw_dev=self.seesaw_dev)
-        except OSError:
-            # Ignore I2C errors
-            pass
-        self.last_encoder_vale = value
-        return value
-    
-    def read_button(self):
-        value = False
-        try:
-            value = read_buttons(pins=(self.button_pin,), seesaw_dev=self.seesaw_dev)[0]
-        except OSError:
-            # Ignore I2C errors
-            pass
-        return value
-
-    def update(self):
-        index = (self.read_encoder() + self.encoder_offset) % len(self.patches)
-        button_state = self.read_button()
-        if (index, button_state) != (self.index, self.button_state):
-            # Only rewrite display if it's out of sync.
-            display.message(self.patch_name(index), 2, inverse=button_state)
-        if button_state:
-            # Button is still down.
-            self.hold_count += 1
-            if self.hold_count == self.hold_max:  # Only act once, at the exact count.
-                # Long hold - perform action (save)
-                name = self.patch_name(index, remove_star=True)
-                save_patch_file(self.patch_dir + '/' + name + self.extension, synth=self.synth)
-                # Flash non-inverse
-                display.message(name, 2, inverse=False)
-                time.sleep(0.1)
-                display.message(name, 2, inverse=True)
-                # Rescan the files (and add a new NEW PATCH if we just materialized one)
-                self.patches = self._list_patches()
-                # Update the offset so that we're still on NEW PATCH if we just wrote it.
-                self.encoder_offset = self.patches.index(name) - self.read_encoder()
-        else:
-            # Button is released.
-            if self.button_state and self.hold_count < self.hold_max:
-                # The button was just released *and* it wasn't a long-hold - perform laod.
-                load_patch_file(self.patch_dir + '/' + self.patch_name(index) + self.extension, synth=self.synth)
-            # Ensure count is reset
-            self.hold_count = 0
-        self.index = index
-        self.button_state = button_state
-
-
-def patch_selector(synth=1, duration=30, seesaw_dev=0x36, encoder=0, button_pin=24,
-                   patch_dir=None, extension='.patch'):
-    """Run the PATCH SELECTOR app using Tulip sequencer."""
-    import sequencer
-    if not web():
-        if display is None or not display.available:
-            print("You need a rotary encoder and OLED display connected")
-            return
-        try:
-            read_encoder(encoder, seesaw_dev=seesaw_dev)
-        except OSError:
-            print("You need a rotary encoder and OLED display connected")
-            return
-    if patch_dir is None:
-        patch_dir = tulip.root_dir() + 'user/current'
-    seq = None
-
-    def exit_callback():
-        # Terminate the sequencing
-        if seq:
-            # Stop sequencer
-            seq.clear()
-            # Clear screen
-            display.clear()
-
-    # Initialize the patch selector
-    patchsel_obj = PatchSelector(synth=synth, seesaw_dev=seesaw_dev, encoder=encoder, button_pin=button_pin,
-                                 patch_dir=patch_dir, extension=extension, exit_callback=exit_callback)
-    # Arrange for it to be called every 32nd note
-    seq = sequencer.TulipSequence(32, lambda x: patchsel_obj.update())
-    return seq, patchsel_obj