Fix several places where we should be filtering negative values.

Author: DaleStan

Yafc/Windows/PreferencesScreen.cs

@@ -41,7 +41,7 @@ public override void Build(ImGui gui) {
             using (gui.EnterRowWithHelpIcon("0 for off, 100% for old default")) {
                 gui.BuildText("Pollution cost modifier", topOffset: 0.5f);
                 DisplayAmount amount = new(settings.PollutionCostModifier, UnitOfMeasure.Percent);
-                if (gui.BuildFloatInput(amount, new Padding(0.5f))) {
+                if (gui.BuildFloatInput(amount, new Padding(0.5f)) && amount.Value >= 0) {
                     settings.RecordUndo().PollutionCostModifier = amount.Value;
                     gui.Rebuild();
                 }

Yafc/Workspace/ProductionTable/ModuleCustomizationScreen.cs

@@ -182,13 +182,8 @@ private void DrawRecipeModules(ImGui gui, EntityBeacon? beacon, ref ModuleEffect
                         }, DataUtils.FavoriteModule);
                         break;
 
-                    case GoodsWithAmountEvent.TextEditing:
-                        int amountInt = MathUtils.Floor(amount.Value);
-                        if (amountInt < 0) {
-                            amountInt = 0;
-                        }
-
-                        rowCustomModule.RecordUndo().fixedCount = amountInt;
+                    case GoodsWithAmountEvent.TextEditing when amount.Value >= 0:
+                        rowCustomModule.RecordUndo().fixedCount = (int)amount.Value;
                         break;
                 }
 

Yafc/Workspace/ProductionTable/ModuleFillerParametersScreen.cs

@@ -49,7 +49,7 @@ private void ListDrawer(ImGui gui, KeyValuePair<EntityCrafter, BeaconOverrideCon
                         }
                     });
                     break;
-                case GoodsWithAmountEvent.TextEditing:
+                case GoodsWithAmountEvent.TextEditing when amount.Value >= 0:
                     modules.RecordUndo().overrideCrafterBeacons[crafter].beaconCount = (int)amount.Value;
                     break;
             }
@@ -168,7 +168,7 @@ public override void Build(ImGui gui) {
                                     }
                                 }, noneTooltip: "Click here to remove the current override.");
                                 return;
-                            case GoodsWithAmountEvent.TextEditing:
+                            case GoodsWithAmountEvent.TextEditing when amount.Value >= 0:
                                 modules.RecordUndo().overrideCrafterBeacons[crafter].beaconCount = (int)amount.Value;
                                 return;
                         }

Yafc/Workspace/ProductionTable/ProductionTableView.cs

@@ -283,7 +283,7 @@ public override void BuildElement(ImGui gui, RecipeRow recipe) {
                     if (recipe.fixedBuildings > 0) {
                         DisplayAmount amount = recipe.fixedBuildings;
                         GoodsWithAmountEvent evt = gui.BuildFactorioObjectWithEditableAmount(recipe.entity, amount, useScale: false);
-                        if (evt == GoodsWithAmountEvent.TextEditing) {
+                        if (evt == GoodsWithAmountEvent.TextEditing && amount.Value >= 0) {
                             recipe.RecordUndo().fixedBuildings = amount.Value;
                         }
 

changelog.txt

@@ -15,6 +15,11 @@
 //     Internal changes: 
 //         Changes to the code that do not affect the behavior of the program.
 ----------------------------------------------------------------------------------------------------------------------
+Version
+Date:
+    Bugfixes:
+        - Refuse to accept negative numbers in several places where they don't make sense.
+----------------------------------------------------------------------------------------------------------------------
 Version 0.8.0
 Date: August 3rd 2024
     Features: