Fix deleting beacon modules (#212)

You could set the number of modules in a beacon to 0, but you couldn't
delete them:

![image](https://github.com/user-attachments/assets/5a107974-4c7a-4e08-ae9b-9a7595c744cd)

Also, when you explicitly set no modules for a recipe, right-clicking
didn't reset them to the default.

![fix-deleting-beacon-modules](https://github.com/user-attachments/assets/458fb75e-a96b-4df7-8c4f-18e90e5a158a)

Author: shpaass

Yafc/Workspace/ProductionTable/ModuleCustomizationScreen.cs

@@ -170,7 +170,8 @@ private void DrawRecipeModules(ImGui gui, EntityBeacon? beacon, ref ModuleEffect
                 if (evt == GoodsWithAmountEvent.LeftButtonClick) {
                     SelectSingleObjectPanel.SelectWithNone(GetModules(beacon), "Select module", sel => {
                         if (sel == null) {
-                            _ = modules.RecordUndo().list.Remove(rowCustomModule);
+                            _ = modules.RecordUndo();
+                            list.Remove(rowCustomModule);
                         }
                         else {
                             rowCustomModule.RecordUndo().module = sel;

Yafc/Workspace/ProductionTable/ProductionTableView.cs

@@ -561,7 +561,7 @@ void drawItem(ImGui gui, FactorioObject? item, int count) {
                         case Click.Left:
                             ShowModuleDropDown(gui, recipe);
                             break;
-                        case Click.Right when item is not null:
+                        case Click.Right when recipe.modules != null:
                             recipe.RecordUndo().RemoveFixedModules();
                             break;
                     }
@@ -597,7 +597,7 @@ private void ShowModuleDropDown(ImGui gui, RecipeRow recipe) {
                     .OrderByDescending(x => x.template.IsCompatibleWith(recipe))];
 
                 gui.ShowDropDown(dropGui => {
-                    if (dropGui.BuildButton("Use default modules").WithTooltip(dropGui, "Shortcut: right-click") && dropGui.CloseDropdown()) {
+                    if (recipe.modules != null && dropGui.BuildButton("Use default modules").WithTooltip(dropGui, "Shortcut: right-click") && dropGui.CloseDropdown()) {
                         recipe.RemoveFixedModules();
                     }
 

changelog.txt

@@ -15,12 +15,14 @@ Version x.y.z
 Date: 
     Features:
         - Autofocus the project name field when you create a new project
+        - When opening the main window, use the same column widths as when it was last closed.
+    Bugfixes:
+        - Sometimes, deleting and/or right-click resetting modules would not work.
 ----------------------------------------------------------------------------------------------------------------------
 Version 0.7.4
 Date: July 24th 2024
     Features:
         - Add the ability to switch through project pages with control-tab and control-shift-tab
-        - When opening the main window, use the same column widths as when it was last closed.
     Bugfixes:
         - Fix a possible threading race while destroying textures, which could cause an illegal access crash.
         - Fix a loading error when mods use non-ASCII characters in their settings.