Skip to content

Commit ea8693a

Browse files
authored
fix: Modify text colors for dark mode readability (#510)
This pull request improves the text contrast for highlighted rows in dark mode. It also simplifies the color scheme setup by not using a magic array. <img width="1809" height="437" alt="image" src="https://github.com/user-attachments/assets/a47bd8e2-93c5-4580-b11c-149b0b56049d" /> Before: <img width="1705" height="434" alt="image" src="https://github.com/user-attachments/assets/aaa99dc2-cf56-40a3-b4fa-3bce7117115e" />
2 parents 26a7a00 + f3ccc8b commit ea8693a

File tree

6 files changed

+289
-49
lines changed

6 files changed

+289
-49
lines changed

Yafc.UI/Core/Structs.cs

Lines changed: 30 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,53 +16,82 @@ public enum SchemeColor {
1616
BackgroundAlt,
1717
BackgroundText,
1818
BackgroundTextFaint,
19+
BackgroundIcon,
20+
BackgroundIconAlt,
1921
// Primary group
2022
Primary,
2123
PrimaryAlt,
2224
PrimaryText,
2325
PrimaryTextFaint,
26+
PrimaryIcon,
27+
PrimaryIconAlt,
2428
// Secondary group
2529
Secondary,
2630
SecondaryAlt,
2731
SecondaryText,
2832
SecondaryTextFaint,
33+
SecondaryIcon,
34+
SecondaryIconAlt,
2935
// Error group
3036
Error,
3137
ErrorAlt,
3238
ErrorText,
3339
ErrorTextFaint,
40+
ErrorIcon,
41+
ErrorIconAlt,
3442
// Grey group
3543
Grey,
3644
GreyAlt,
3745
GreyText,
3846
GreyTextFaint,
47+
GreyIcon,
48+
GreyIconAlt,
3949
// Magenta group (indicate overproduction)
4050
Magenta,
4151
MagentaAlt,
4252
MagentaText,
4353
MagentaTextFaint,
54+
MagentaIcon,
55+
MagentaIconAlt,
4456
// Green group
4557
Green,
4658
GreenAlt,
4759
GreenText,
4860
GreenTextFaint,
61+
GreenIcon,
62+
GreenIconAlt,
63+
// Warning group (for warning icons like "!" triangle)
64+
Warning,
65+
WarningAlt,
66+
WarningText,
67+
WarningTextFaint,
68+
WarningIcon,
69+
WarningIconAlt,
4970
// Tagged row colors
5071
TagColorGreen,
5172
TagColorGreenAlt,
5273
TagColorGreenText,
5374
TagColorGreenTextFaint,
75+
TagColorGreenIcon,
76+
TagColorGreenIconAlt,
5477
TagColorYellow,
5578
TagColorYellowAlt,
5679
TagColorYellowText,
5780
TagColorYellowTextFaint,
81+
TagColorYellowIcon,
82+
TagColorYellowIconAlt,
5883
TagColorRed,
5984
TagColorRedAlt,
6085
TagColorRedText,
6186
TagColorRedTextFaint,
87+
TagColorRedIcon,
88+
TagColorRedIconAlt,
6289
TagColorBlue,
6390
TagColorBlueAlt,
6491
TagColorBlueText,
65-
TagColorBlueTextFaint
92+
TagColorBlueTextFaint,
93+
TagColorBlueIcon,
94+
TagColorBlueIconAlt
6695
}
6796

6897
public enum SchemeColorGroup {

0 commit comments

Comments
 (0)