fix session stats reset on changed pool settings

Author: Pmaxsd

main/stratum/stratum_manager.cpp

@@ -302,6 +302,9 @@ void StratumManager::loadSettings(bool reconnect)
             m_stratumTasks[i]->triggerReconnect();
         }
 
+        // reset session stats for this pool
+        resetPoolSessionStats(i);
+
         // reset ping stats
         if (m_pingTasks[i]) {
             m_pingTasks[i]->reset();

main/stratum/stratum_manager.h

@@ -98,6 +98,10 @@ class StratumManager {
 
     virtual int getPoolMode() = 0;
 
+    // reset stats for a single pool (called from loadSettings with mutex held)
+    virtual void resetPoolSessionStats(int pool) {
+    }
+
   public:
     virtual void resetSessionStats() {
         PThreadGuard lock(m_mutex);

main/stratum/stratum_manager_dual_pool.h

@@ -97,15 +97,19 @@ class StratumManagerDualPool : public StratumManager {
         return (m_balance >= 50) ? m_networkDifficulty[0] : m_networkDifficulty[1];
     }
 
+    virtual void resetPoolSessionStats(int pool) override {
+        StratumManager::resetPoolSessionStats(pool);
+        m_accepted[pool] = 0;
+        m_rejected[pool] = 0;
+        m_bestSessionDiff[pool] = 0;
+        suffixString(std::max(m_bestSessionDiff[0], m_bestSessionDiff[1]), m_bestSessionDiffString, DIFF_STRING_SIZE, 0);
+        if (m_stratumTasks[pool]) m_stratumTasks[pool]->m_poolErrors = 0;
+    }
+
     virtual void resetSessionStats() override {
         PThreadGuard lock(m_mutex);
-        m_foundBlocks = 0;
         for (int i = 0; i < 2; i++) {
-            m_accepted[i] = 0;
-            m_rejected[i] = 0;
-            m_bestSessionDiff[i] = 0;
-            suffixString(0, m_bestSessionDiffString, DIFF_STRING_SIZE, 0);
-            if (m_stratumTasks[i]) m_stratumTasks[i]->m_poolErrors = 0;
+            resetPoolSessionStats(i);
         }
     }
 

main/stratum/stratum_manager_fallback.h

@@ -80,15 +80,20 @@ class StratumManagerFallback : public StratumManager {
         return m_networkDifficulty;
     }
 
-    virtual void resetSessionStats() override {
-        PThreadGuard lock(m_mutex);
-        m_foundBlocks = 0;
+    virtual void resetPoolSessionStats(int pool) override {
+        StratumManager::resetPoolSessionStats(pool);
+        // fallback mode shares a single counter for both pools
         m_accepted = 0;
         m_rejected = 0;
         m_bestSessionDiff = 0;
         suffixString(0, m_bestSessionDiffString, DIFF_STRING_SIZE, 0);
+        if (m_stratumTasks[pool]) m_stratumTasks[pool]->m_poolErrors = 0;
+    }
+
+    virtual void resetSessionStats() override {
+        PThreadGuard lock(m_mutex);
         for (int i = 0; i < 2; i++) {
-            if (m_stratumTasks[i]) m_stratumTasks[i]->m_poolErrors = 0;
+            resetPoolSessionStats(i);
         }
     }
 

main/system.cpp

@@ -290,7 +290,7 @@ void System::task() {
         uint32_t foundBlocks = STRATUM_MANAGER->getFoundBlocks();
 
         // trigger the overlay only once when block is found
-        if (foundBlocks != lastFoundBlocks && foundBlocks) {
+        if (foundBlocks > lastFoundBlocks) {
             m_display->showFoundBlockOverlay();
         }
         lastFoundBlocks = foundBlocks;