added overflow check

shukriadams · shukriadams · commit 9abaf62d558d · 2024-12-10T13:45:26.000+01:00
diff --git a/src/Tetrifact.Core/Percent.cs b/src/Tetrifact.Core/Percent.cs
@@ -11,6 +11,10 @@ public class Percent
         /// <returns></returns>
         public static int Calc(decimal first, decimal second)
         {
+            // overflow check
+            if (second == 0)
+                return 0;
+
             decimal p = first / second;
             return (int)System.Math.Round((decimal)(p * 100), 0);
         }
@@ -23,6 +27,10 @@ public static int Calc(decimal first, decimal second)
         /// <returns></returns>
         public static int Calc(double first, double second)
         {
+            // overflow check
+            if (second == 0)
+                return 0;
+
             double p = first / second;
             return (int)System.Math.Round((double)(p * 100), 0);
         }

Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,10 @@ public class Percent`
`11`	`11`	`/// <returns></returns>`
`12`	`12`	`public static int Calc(decimal first, decimal second)`
`13`	`13`	`{`
	`14`	`+ // overflow check`
	`15`	`+ if (second == 0)`
	`16`	`+ return 0;`
	`17`	`+`
`14`	`18`	`decimal p = first / second;`
`15`	`19`	`return (int)System.Math.Round((decimal)(p * 100), 0);`
`16`	`20`	`}`
`@@ -23,6 +27,10 @@ public static int Calc(decimal first, decimal second)`
`23`	`27`	`/// <returns></returns>`
`24`	`28`	`public static int Calc(double first, double second)`
`25`	`29`	`{`
	`30`	`+ // overflow check`
	`31`	`+ if (second == 0)`
	`32`	`+ return 0;`
	`33`	`+`
`26`	`34`	`double p = first / second;`
`27`	`35`	`return (int)System.Math.Round((double)(p * 100), 0);`
`28`	`36`	`}`