Merge pull request #33 from jurgenbosch/feature/verify-image-url

shweshi · web-flow · commit 7d7a5d9960a6 · 2019-07-20T21:52:43.000+05:30
Handling non valid image urls
diff --git a/src/OpenGraph.php b/src/OpenGraph.php
@@ -81,6 +81,10 @@ protected function curl_get_contents($url, $lang)
 
     protected function verify_image_url($url)
     {
+        if (!filter_var($url, FILTER_VALIDATE_URL)) {
+            return false;
+        }
+
         $headers = get_headers($url);
 
         return stripos($headers[0], '200 OK') ? true : false;
diff --git a/tests/OpenGraphTest.php b/tests/OpenGraphTest.php
@@ -46,4 +46,17 @@ public function testFetchReturnsEmptyArrayForWebsiteWithNoMetadata()
 
         $this->assertEmpty($data);
     }
+
+    /** @test */
+    public function testFetchMustacheMetasData()
+    {
+        $opengraph = new OpenGraph();
+        $data = $opengraph->fetch(
+            'https://raw.githubusercontent.com/jurgenbosch/OpenGraph/master/tests/__mocks__/angular-headers.html', true
+        );
+        $this->assertArrayHasKey('title', $data);
+        $this->assertArrayHasKey('description', $data);
+        $this->assertArrayHasKey('image', $data);
+        $this->assertEmpty($data['image']);
+    }
 }
diff --git a/tests/__mocks__/angular-headers.html b/tests/__mocks__/angular-headers.html
@@ -0,0 +1,26 @@
+<!doctype html>
+<!--[if lt IE 7]>      <html class="no-js lt-ie9 lt-ie8 lt-ie7"> <![endif]-->
+<!--[if IE 7]>         <html class="no-js lt-ie9 lt-ie8"> <![endif]-->
+<!--[if IE 8]>         <html xmlns:ng="https://angularjs.org" class="no-js lt-ie9" id="ng-app" data-ng-app="skeletonApp"> <![endif]-->
+<!--[if gt IE 8]><!--> <html class="no-js" style="height: 100%; background-color: #ffffff;" data-ng-app="skeletonApp"> <!--<![endif]-->
+<head>
+    <meta charset="utf-8">
+    <meta http-equiv="X-UA-Compatible" content="IE=edge">
+    <title>Example</title>
+    <meta name="description" content="{{ pageDescription }}" />
+    <meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=no" />
+
+    <meta property="og:title" content="{{ pageTitle }}" />
+    <meta property="og:description" content="{{ pageDescription }}" />
+    <meta property="og:image" content="{{ picturePath }}" />
+
+    <meta name="theme-color" content="{{ themeColor }}">
+    <meta name="msapplication-navbutton-color" content="{{ themeColor }}">
+    <meta name="apple-mobile-web-app-status-bar-style" content="{{ themeColor }}" />
+    <meta name="{{ indexName }}" content="{{ indexContent }}">
+    <link rel="canonical" href="{{ canonicalUrl }}" />
+</head>
+<body>
+    Body here
+</body>
+</html>

Original file line number	Diff line number	Diff line change
`@@ -81,6 +81,10 @@ protected function curl_get_contents($url, $lang)`
`81`	`81`
`82`	`82`	`protected function verify_image_url($url)`
`83`	`83`	`{`
	`84`	`+ if (!filter_var($url, FILTER_VALIDATE_URL)) {`
	`85`	`+ return false;`
	`86`	`+ }`
	`87`	`+`
`84`	`88`	`$headers = get_headers($url);`
`85`	`89`
`86`	`90`	`return stripos($headers[0], '200 OK') ? true : false;`