Skip to content

#230 into release@5.0.0 🧊 fix timer for test#239

Open
debabin wants to merge 1 commit into
release@5.0.0from
#230
Open

#230 into release@5.0.0 🧊 fix timer for test#239
debabin wants to merge 1 commit into
release@5.0.0from
#230

Conversation

@debabin

@debabin debabin commented May 3, 2025

Copy link
Copy Markdown
Member

No description provided.

@coderabbitai

coderabbitai Bot commented May 3, 2025

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@debabin debabin linked an issue May 3, 2025 that may be closed by this pull request
The tests depend on the time zone and fall in other zones #230
Closed
MiaInturi
MiaInturi requested changes Jan 4, 2026
View reviewed changes
Comment thread src/utils/helpers/date/formatTimestamp/formatTimestamp.test.ts
Comment on lines +3 to +7
vi.useFakeTimers().setSystemTime(new Date('1999-03-12'));

describe('formatTimestamp', () => {
it('Should correctly format timestamp', () => {
expect(formatTimestamp(1735623296789)).toBe('31.12.2024, 12:34:56,789');
expect(formatTimestamp(944199296789)).toBe('03.12.1999, 12:34:56,789');

@MiaInturi MiaInturi Jan 4, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это по факту не лечит проблему, это лишь сдвигает date.now (таймстамп), но проблема не в таймстампе, а в том, как он отображается — один и тот же таймстамп отображается по разному в разных часовых поясах.

TZ=Europe/Berlin yarn unit-test src/utils/helpers/date/formatTimestamp/formatTimestamp.test.ts если запустить тест, то можно увидеть, что проблема все еще актуальна.

Короче, я думаю надо просто в vitest конфиг запихать переменную окружения TZ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MiaInturi MiaInturi MiaInturi requested changes

@RiceWithMeat RiceWithMeat RiceWithMeat approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The tests depend on the time zone and fall in other zones

3 participants

@debabin @MiaInturi @RiceWithMeat