feature/init-cli into feature/graphql-sub 🧊 rebuild init cli#274
feature/init-cli into feature/graphql-sub 🧊 rebuild init cli#274debabin wants to merge 2 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR rebuilds the Key changes:
Confidence Score: 3/5Not safe to merge as-is — two JS GraphQL templates contain a runtime bug that breaks GetUser for all JS users choosing GraphQL or Full API presets. The TS templates and CLI logic are well-implemented, but the JS graphql and JS full templates both use params.request.params.id inside a GraphQL handler (a copy-paste from REST logic), causing GetUser to always return 404. These are user-facing generated files, so the bug would be immediately apparent to every JS user who runs the generated code. The docs are also incomplete regarding the new playground options. packages/server/bin/templates/js/graphql/mock-server.config.js and packages/server/bin/templates/js/full/mock-server.config.js require fixes before merging. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A([mcs init]) --> B{Would you like\nto use TypeScript?}
B -->|Yes| C[TS templates]
B -->|No| D[JS templates]
C --> E{Choose API type}
D --> E
E --> F[rest]
E --> G[rest-playground]
E --> H[graphql]
E --> I[graphql-playground]
E --> J[ws]
E --> K[full]
F & G & H & I & J & K --> L[Prompt: baseUrl · port · staticPath]
L --> M[createTemplate]
M --> N[Read template mock-server.config file]
N --> O[Replace port / baseUrl / staticPath tokens]
O --> P([Write mock-server.config.ts/js])
style H fill:#f88,stroke:#c00
style I fill:#ffd,stroke:#aa0
style D fill:#f88,stroke:#c00
|
No description provided.