FS#9099

Do not send a fetch request, in case dataprovider name is null.

Author: mhandsteiner

src/main/components/editors/linked/UIEditorLinked.tsx

@@ -124,24 +124,26 @@ export function fetchLinkedRefDatabook(
     name?: string, 
     decreaseCallback?: Function
 ) {
-    const refDataBookInfo = contentStore.getDataBook(screenName, databook);
-    if (selectedRecord !== undefined
-        && (displayCol || concatMask)
-        && (!refDataBookInfo?.data)
-        && !server.missingDataFetches.includes(databook)) {
-        server.missingDataFetches.push(databook);
-        const fetchReq = createFetchRequest();
-        fetchReq.dataProvider = databook;
-        fetchReq.fromRow = 0;
-        fetchReq.rowCount = 100;
-        if (!refDataBookInfo?.metaData) {
-            fetchReq.includeMetaData = true;
-        }
-        if (refDataBookInfo?.isAllFetched) {
-            refDataBookInfo.isAllFetched = undefined;
+    if (databook) {
+        const refDataBookInfo = contentStore.getDataBook(screenName, databook);
+        if (selectedRecord !== undefined
+            && (displayCol || concatMask)
+            && (!refDataBookInfo?.data)
+            && !server.missingDataFetches.includes(databook)) {
+            server.missingDataFetches.push(databook);
+            const fetchReq = createFetchRequest();
+            fetchReq.dataProvider = databook;
+            fetchReq.fromRow = 0;
+            fetchReq.rowCount = 100;
+            if (!refDataBookInfo?.metaData) {
+                fetchReq.includeMetaData = true;
+            }
+            if (refDataBookInfo?.isAllFetched) {
+                refDataBookInfo.isAllFetched = undefined;
+            }
+            fetchReq.screenName = screenName;
+            server.sendRequest(fetchReq, REQUEST_KEYWORDS.FETCH).then(() => decreaseCallback ? decreaseCallback(databook) : undefined)
         }
-        fetchReq.screenName = screenName;
-        server.sendRequest(fetchReq, REQUEST_KEYWORDS.FETCH).then(() => decreaseCallback ? decreaseCallback(databook) : undefined)
     }
 }
 

src/main/components/table/UITable.tsx

@@ -1295,7 +1295,7 @@ const UITable: FC<TableProps & IExtendableTable & IComponentConstants> = (props)
         ) {
             last = Math.max(first, last);
             //setListLoading(true);
-            if((providerData.length <= last) && !props.context.contentStore.getDataBook(screenName, props.dataBook)?.isAllFetched) {
+            if(props.dataBook && (providerData.length <= last) && !props.context.contentStore.getDataBook(screenName, props.dataBook)?.isAllFetched) {
                 const fetchReq = createFetchRequest();
                 fetchReq.dataProvider = props.dataBook;
                 fetchReq.fromRow = providerData.length;
@@ -1666,22 +1666,24 @@ width: ${width}px !important; max-width: ${width}px !important; }`;
 
     // initially fetch more rows until you have 100
     useEffect(() => {
-        const dataBook = props.context.contentStore.getDataBook(screenName, props.dataBook)
-        if (!dataBook?.isAllFetched && providerData.length < rows) {
-            const fetchReq = createFetchRequest();
-            fetchReq.dataProvider = props.dataBook;
-            fetchReq.fromRow = providerData.length;
-            fetchReq.rowCount = 100;
-            const server = props.context.server;
-            if (!dataBook?.metaData) {
-                fetchReq.includeMetaData = true;
+        if (props.dataBook) {
+            const dataBook = props.context.contentStore.getDataBook(screenName, props.dataBook)
+            if (!dataBook?.isAllFetched && providerData.length < rows) {
+                const fetchReq = createFetchRequest();
+                fetchReq.dataProvider = props.dataBook;
+                fetchReq.fromRow = providerData.length;
+                fetchReq.rowCount = 100;
+                const server = props.context.server;
+                if (!dataBook?.metaData) {
+                    fetchReq.includeMetaData = true;
+                }
+                if (!dataBook?.data && !server.missingDataFetches.includes(props.dataBook)) {
+                    server.missingDataFetches.push(props.dataBook);
+                    showTopBar(server.sendRequest(fetchReq, REQUEST_KEYWORDS.FETCH), server.topbar);
+                } else if(dataBook?.data) {
+                    showTopBar(server.sendRequest(fetchReq, REQUEST_KEYWORDS.FETCH), server.topbar);
+                }
             }
-            if (!dataBook?.data && !server.missingDataFetches.includes(props.dataBook)) {
-                server.missingDataFetches.push(props.dataBook);
-                showTopBar(server.sendRequest(fetchReq, REQUEST_KEYWORDS.FETCH), server.topbar);
-            } else if(dataBook?.data) {
-                showTopBar(server.sendRequest(fetchReq, REQUEST_KEYWORDS.FETCH), server.topbar);
-            }            
         }
     }, [providerData, screenName, props.dataBook])
 

src/main/components/tree/UITree.tsx

@@ -413,20 +413,22 @@ const UITree: FC<ITree & IExtendableTree & IComponentConstants> = (props) => {
              * @returns the datarows of the root page
              */
             const fetchRoot = async () => {
-                const fetchReq = createFetchRequest();
-                fetchReq.dataProvider = firstLvlDataBook;
-                fetchReq.fromRow = 0;
-                fetchReq.rowCount = -1;
-                fetchReq.filter = {
-                    columnNames: [],
-                    values: []
-                }
-                fetchReq.rootKey = true;
-                const fetchResponse = await showTopBar(props.context.server.sendRequest(fetchReq, REQUEST_KEYWORDS.FETCH), props.topbar);
-                if (fetchResponse && fetchResponse.length) {
-                    const rootKey = props.context.contentStore.getDataBook(screenName, firstLvlDataBook)?.rootKey;
-                    if (rootKey) {
-                        return providedData.get(firstLvlDataBook).get(rootKey)
+                if (firstLvlDataBook) {
+                    const fetchReq = createFetchRequest();
+                    fetchReq.dataProvider = firstLvlDataBook;
+                    fetchReq.fromRow = 0;
+                    fetchReq.rowCount = -1;
+                    fetchReq.filter = {
+                        columnNames: [],
+                        values: []
+                    }
+                    fetchReq.rootKey = true;
+                    const fetchResponse = await showTopBar(props.context.server.sendRequest(fetchReq, REQUEST_KEYWORDS.FETCH), props.topbar);
+                    if (fetchResponse && fetchResponse.length) {
+                        const rootKey = props.context.contentStore.getDataBook(screenName, firstLvlDataBook)?.rootKey;
+                        if (rootKey) {
+                            return providedData.get(firstLvlDataBook).get(rootKey)
+                        }
                     }
                 }
                 return []