Skip to content

Commit 50f8148

Browse files
committed
fix: default options on startup
Fixes #244 The problem was that the default value was unused unless passed explicitly via the flag. Fix by exposing the registry refresh interval, but also ensure that options defaults are set even if they don't have a flag. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
1 parent 29b022e commit 50f8148

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

cmd/image-factory/flags.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,16 @@ import (
1212
)
1313

1414
func initFlags() cmd.Options {
15-
var opts cmd.Options
15+
opts := cmd.DefaultOptions
1616

1717
flag.StringVar(&opts.HTTPListenAddr, "http-port", cmd.DefaultOptions.HTTPListenAddr, "HTTP listen address")
1818

1919
flag.StringVar(&opts.MinTalosVersion, "min-talos-version", cmd.DefaultOptions.MinTalosVersion, "minimum Talos version")
2020
flag.StringVar(&opts.ImageRegistry, "image-registry", cmd.DefaultOptions.ImageRegistry, "image registry for imager, extensions, etc.")
2121
flag.BoolVar(&opts.InsecureImageRegistry, "insecure-image-registry", cmd.DefaultOptions.InsecureImageRegistry, "allow an insecure connection to the image registry")
2222

23+
flag.DurationVar(&opts.RegistryRefreshInterval, "registry-refresh-interval", cmd.DefaultOptions.RegistryRefreshInterval, "image registry refresh interval")
24+
2325
flag.StringVar(&opts.ContainerSignatureSubjectRegExp, "container-signature-subject-regexp", cmd.DefaultOptions.ContainerSignatureSubjectRegExp, "container signature subject regexp")
2426
flag.StringVar(&opts.ContainerSignatureIssuerRegExp, "container-signature-issuer-regexp", cmd.DefaultOptions.ContainerSignatureIssuerRegExp, "container signature issuer regexp")
2527
flag.StringVar(&opts.ContainerSignatureIssuer, "container-signature-issuer", cmd.DefaultOptions.ContainerSignatureIssuer, "container signature issuer")

0 commit comments

Comments
 (0)