feat: update helm docs disable flag to cover enforcing doc generation

Just removing helm docs step is not enough to stop enforcement of helm doc generation. Add schema generation and check dirty steps as well for full coverage.

Signed-off-by: Oguz Kilcan <oguz.kilcan@siderolabs.com>

Author: oguzkilcan

internal/project/auto/helm.go

@@ -64,7 +64,7 @@ func (builder *builder) DetectHelm() (bool, error) {
 	}
 
 	builder.meta.HelmTemplateFlags = flags
-	builder.meta.HelmDocsDisabled = helm.DocsDisabled
+	builder.meta.EnforceHelmDocs = !helm.DocsDisabled
 
 	return true, nil
 }

internal/project/helm/build.go

@@ -11,8 +11,6 @@ import (
 	"slices"
 	"strings"
 
-	"github.com/siderolabs/gen/xslices"
-
 	"github.com/siderolabs/kres/internal/config"
 	"github.com/siderolabs/kres/internal/dag"
 	"github.com/siderolabs/kres/internal/output/dockerfile"
@@ -259,22 +257,18 @@ func (helm *Build) CompileGitHubWorkflow(output *ghworkflow.Output) error {
 		loginStep,
 		lintStep,
 		templateStep,
-		unittestPluginInstallStep,
-		unittestStep,
-		schemaStep,
-		docsStep,
-		checkDirtyStep,
-		helmLoginStep,
-		helmReleaseStep,
 	}
 
-	jobSteps = xslices.Filter(jobSteps, func(step *ghworkflow.JobStep) bool {
-		if helm.meta.HelmDocsDisabled && step.Name == "Generate docs" {
-			return false
-		}
+	// Add steps for unit tests
+	jobSteps = append(jobSteps, []*ghworkflow.JobStep{unittestPluginInstallStep, unittestStep}...)
 
-		return true
-	})
+	// Add steps for schema generation and docs generation if enforced
+	if helm.meta.EnforceHelmDocs {
+		jobSteps = append(jobSteps, []*ghworkflow.JobStep{schemaStep, docsStep, checkDirtyStep}...)
+	}
+
+	// Add final steps
+	jobSteps = append(jobSteps, []*ghworkflow.JobStep{helmLoginStep, helmReleaseStep}...)
 
 	output.AddWorkflow("helm", &ghworkflow.Workflow{
 		Name: "helm",

internal/project/meta/meta.go

@@ -110,8 +110,8 @@ type Options struct { //nolint:govet
 	// SOPSEnabled indicates whether SOPS is enabled for the project.
 	SOPSEnabled bool
 
-	// HelmDocsDisabled indicates whether Helm docs should be disabled.
-	HelmDocsDisabled bool
+	// EnforceHelmDocs indicates whether usage of helm docs should be enforced.
+	EnforceHelmDocs bool
 }
 
 // Command defines Golang executable build configuration.