fix: generate also depends on generate-* targets

This also fixes a blindspot in the check-dirty target, which would miss
stale artifacts if they were generated by additional "generate-*"
targets.

Signed-off-by: Maja Bojarska <maja.bojarska@siderolabs.com>

Author: majabojarska

internal/project/js/protobuf.go

@@ -76,10 +76,15 @@ func (proto *Protobuf) CompileMakefile(output *makefile.Output) error {
 		return nil
 	}
 
-	output.Target("generate-" + proto.Name()).
+	targetName := "generate-" + proto.Name()
+	output.Target(targetName).
 		Description("Generate .proto definitions.").
 		Script("@$(MAKE) local-$@ DEST=./")
 
+	if output.HasTarget("generate") {
+		output.Target("generate").Depends(targetName)
+	}
+
 	return nil
 }
 
@@ -194,7 +199,9 @@ func (proto *Protobuf) CompileLefthook(output *lefthook.Output) error {
 	output.Hook(lefthook.HookGroupPreCommit).
 		Group(lefthook.PreCommitFixStage).
 		WithParallel(false).
-		Job().WithName("generate " + proto.Name()).WithRun("make generate-" + proto.Name()).WithStageFixed()
+		Job().
+		WithName("generate " + proto.Name()).
+		WithRun("make generate-" + proto.Name()).WithStageFixed()
 
 	return nil
 }

internal/project/js/protobuf_test.go

@@ -24,6 +24,51 @@ func TestProtobufInterfaces(t *testing.T) {
 	assert.Implements(t, (*lefthook.Compiler)(nil), new(js.Protobuf))
 }
 
+func TestProtobufMakefileGenerateDepends(t *testing.T) {
+	for _, tt := range []struct {
+		name               string
+		registerCheckDirty bool
+		wantDepends        bool
+	}{
+		{
+			name:               "generate target depends on generate-frontend",
+			registerCheckDirty: true,
+			wantDepends:        true,
+		},
+		{
+			name:               "no generate target leaves generate-frontend orphan",
+			registerCheckDirty: false,
+			wantDepends:        false,
+		},
+	} {
+		t.Run(tt.name, func(t *testing.T) {
+			proto := js.NewProtobuf(&meta.Options{}, "frontend")
+			proto.Specs = []js.ProtoSpec{{Source: "api.proto"}}
+
+			output := makefile.NewOutput()
+
+			if tt.registerCheckDirty {
+				output.Target("generate")
+			}
+
+			require.NoError(t, proto.CompileMakefile(output))
+
+			var buf bytes.Buffer
+
+			require.NoError(t, output.GenerateFile("Makefile", &buf))
+
+			rendered := buf.String()
+			assert.Contains(t, rendered, "generate-frontend:")
+
+			if tt.wantDepends {
+				assert.Contains(t, rendered, "generate: generate-frontend")
+			} else {
+				assert.NotContains(t, rendered, "generate:")
+			}
+		})
+	}
+}
+
 func TestProtobufLefthook(t *testing.T) {
 	proto := js.NewProtobuf(&meta.Options{}, "frontend")