fix: make iscsiadm script work with any POSIX shell #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frezbo
reviewed
Oct 17, 2024
sbogomolov
force-pushed
the
v1.31.1-iscsi-fix
branch
from
fe920b3 to
dfe061f
Compare
frezbo
approved these changes
Oct 17, 2024
frezbo
force-pushed
the
v1.31.1-iscsi-fix
branch
from
dfe061f to
d6b96c3
Compare
Fix iscsiadm script. Signed-off-by: Noel Georgi <[email protected]>
frezbo
force-pushed
the
v1.31.1-iscsi-fix
branch
from
d6b96c3 to
34b87b3
Compare
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changed the shell used to run this script from
bashtosh. This PR fixes the script to work withsh.