updated the code

Author: malavikakrishnan123

src/LCT.Common/Logging/LoggerHelper.cs

@@ -674,7 +674,7 @@ private static void DisplaySettingsWithLogger(List<string> projectTypes, Diction
 
             foreach (var projectType in projectTypes)
             {
-                Logger.Info(projectType + ":\n\t");
+                Logger.InfoFormat("{0}:\n\t", projectType);
 
                 if (projectConfigMap.TryGetValue(projectType, out var config))
                 {
@@ -1256,9 +1256,10 @@ public static void WriteToConsoleTable(Dictionary<string, int> printData, Dictio
             const string TimeTakenBy = "Time Taken By";
             string separator = $"{"=",5}{string.Join("", Enumerable.Repeat("=", 88)),5}";
 
-            Logger.Info("\nSummary :\n" + 
+            string summaryHeader = "\nSummary :\n" + 
                 (!string.IsNullOrWhiteSpace(ProjectSummaryLink) ? ProjectSummaryLink + "\n" : "") + 
-                separator);
+                separator;
+            Logger.Info(summaryHeader);
             Logger.InfoFormat("{0,5}{1,-70} {2,5} {3,5} {4,5}\n{6}", "|", Feature, "|", Count, "|", "", separator);
 
             foreach (var item in printData)
@@ -1284,7 +1285,7 @@ private static void LogTableRow(string key, int value)
 
             if ((key == "Packages Not Uploaded Due To Error" || key == "Packages Not Existing in Remote Cache") && value > 0)
             {
-                Logger.Error(row + "\n" + separator);
+                Logger.ErrorFormat("{0}\n{1}", row, separator);
             }
             else
             {
@@ -1686,11 +1687,11 @@ public static void WriteFossologyStatusMessage(string message)
             if (LoggerFactory.UseSpectreConsole)
             {
                 WriteInfoWithMarkup($"   [white]└──[/][yellow]{message}[/]");
-                Logger.Debug("   └── " + message);
+                Logger.DebugFormat("   └── {0}", message);
             }
             else
             {
-                Logger.Warn("\t" + message);
+                Logger.WarnFormat("\t{0}", message);
             }
         }
         /// <summary>
@@ -1702,11 +1703,11 @@ public static void WriteFossologyExceptionMessage(string message)
             if (LoggerFactory.UseSpectreConsole)
             {
                 WriteInfoWithMarkup($"   [white]└──[/][red]{message}[/]");
-                Logger.Debug("   └── " + message);
+                Logger.DebugFormat("   └── {0}", message);
             }
             else
             {
-                Logger.Error("\t" + message);
+                Logger.ErrorFormat("\t{0}", message);
             }
         }
         /// <summary>
@@ -1756,7 +1757,7 @@ public static void MSBuildVersionDisplay(string message, string version)
             }
             else
             {
-                Logger.Info(message + version);
+                Logger.InfoFormat("{0}{1}", message, version);
             }
         }
         /// <summary>

src/LCT.SW360PackageCreator/PackageDownloader.cs

@@ -136,35 +136,29 @@ private static string GetCorrectVersion(ComparisonBomData component)
             string[] taglist = GetTagListFromResult(result);
             string baseVersion = GetBaseVersion(component.Version);
 
-            foreach (string item in taglist)
+            foreach (string item in taglist.Where(x => !string.IsNullOrWhiteSpace(x)))
             {
-                if (!string.IsNullOrWhiteSpace(item))
-                {
-                    string tag = item[(item.IndexOf("tags/") + 5)..];
-                    Logger.DebugFormat("baseobject - {0},Identifying tag -{1}", item, tag);
+                string tag = item[(item.IndexOf("tags/") + 5)..];
+                Logger.DebugFormat("baseobject - {0},Identifying tag -{1}", item, tag);
 
-                    if (tag.Contains(component.Version, StringComparison.OrdinalIgnoreCase) &&
+                if (tag.Contains(component.Version, StringComparison.OrdinalIgnoreCase) &&
                 tag.Contains(component.Name, StringComparison.OrdinalIgnoreCase))
-                    {
-                        return tag;
-                    }
+                {
+                    return tag;
                 }
             }
-            foreach (string item in taglist)
+            foreach (string item in taglist.Where(x => !string.IsNullOrWhiteSpace(x)))
             {
-                if (!string.IsNullOrWhiteSpace(item))
-                {
-                    string tag = item[(item.IndexOf("tags/") + 5)..];
-                    Logger.DebugFormat("baseobject - {0},Identifying tag -{1}", item, tag);
+                string tag = item[(item.IndexOf("tags/") + 5)..];
+                Logger.DebugFormat("baseobject - {0},Identifying tag -{1}", item, tag);
 
-                    if (tag.Contains(component.Version))
-                    {
-                        return tag;
-                    }
-                    else if (tag.Contains(baseVersion))
-                    {
-                        return tag;
-                    }
+                if (tag.Contains(component.Version))
+                {
+                    return tag;
+                }
+                else if (tag.Contains(baseVersion))
+                {
+                    return tag;
                 }
             }
             Logger.DebugFormat("GetCorrectVersion():Completed identifying correct version for this component ,given version:{0}, correct Version:{1}", component.Version, correctVersion);

src/LCT.Services/Sw360CreatorService.cs

@@ -1047,7 +1047,7 @@ public async Task<FossTriggerStatus> TriggerFossologyProcessForValidation(string
             {
                 if (ex.Message == "500:Connection to Fossology server Failed.")
                 {
-                    Logger.Error("Fossology process failed.Please check fossology configuration or Token in sw360");
+                    Logger.Error("Fossology process failed.Please check fossology configuration or Token in sw360", ex);
                     environmentHelper.CallEnvironmentExit(-1);
                 }
             }