Skip to content

Commit 7e8c24d

Browse files
authored
Merge pull request #379 from siemens/bugfix/Multiprojecttypeissue
fix: Fix for multiproject type issue in package identifier.
2 parents 679373f + bc0d721 commit 7e8c24d

File tree

3 files changed

+3
-49
lines changed

3 files changed

+3
-49
lines changed

src/LCT.PackageIdentifier.UTest/CommonIdentiferHelperTests.cs

Lines changed: 1 addition & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -66,38 +66,7 @@ public void GetRepodetailsFromPerticularOrder_NoSpecificRepo_ReturnsFirstRepo()
6666
};
6767
var result = CommonIdentiferHelper.GetRepodetailsFromPerticularOrder(aqlResults);
6868
Assert.AreEqual("generic-repo", result);
69-
}
70-
[Test]
71-
public void GetBomFileName_WhenBasicSBOMIsFalse_ReturnsProjectNameBomFileName()
72-
{
73-
// Arrange
74-
var appSettings = new CommonAppSettings
75-
{
76-
SW360 = new SW360() { ProjectName = "TestProject" }
77-
};
78-
79-
// Act
80-
string result = CommonIdentiferHelper.GetBomFileName(appSettings);
81-
82-
// Assert
83-
Assert.AreEqual("TestProject_Bom.cdx.json", result);
84-
}
85-
86-
[Test]
87-
public void GetBomFileName_WhenBasicSBOMIsTrue_ReturnsBasicSBOMNameBomFileName()
88-
{
89-
// Arrange
90-
var appSettings = new CommonAppSettings
91-
{
92-
93-
};
94-
95-
// Act
96-
string result = CommonIdentiferHelper.GetBomFileName(appSettings);
97-
98-
// Assert
99-
Assert.AreEqual(FileConstant.basicSBOMName + "_Bom.cdx.json", result);
100-
}
69+
}
10170

10271
[Test]
10372
public void GetDefaultProjectName_WhenBasicSBOMIsFalse_ReturnsProjectName()

src/LCT.PackageIdentifier/BomCreator.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,8 +136,7 @@ private static void WritecontentsToBOM(CommonAppSettings appSettings, BomKpiData
136136
private static void WriteContentToCycloneDxBOM(CommonAppSettings appSettings, Bom listOfComponentsToBom, ref BomKpiData bomKpiData, string defaultProjectName)
137137
{
138138
FileOperations fileOperations = new FileOperations();
139-
string bomFileName = CommonIdentiferHelper.GetBomFileName(appSettings);
140-
139+
string bomFileName = $"{defaultProjectName}_{FileConstant.BomFileName}";
141140
string outputFolderPath = appSettings.Directory.OutputFolder;
142141
string[] files = Directory.GetFiles(outputFolderPath);
143142

src/LCT.PackageIdentifier/CommonIdentiferHelper.cs

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -52,21 +52,7 @@ private static string FindRepositoryByKeywords(List<AqlResult> aqlResults, strin
5252
}
5353
}
5454
return null;
55-
}
56-
public static string GetBomFileName(CommonAppSettings appSettings)
57-
{
58-
string bomFileName;
59-
if (appSettings.SW360 != null)
60-
{
61-
bomFileName = $"{appSettings.SW360.ProjectName}_Bom.cdx.json";
62-
}
63-
else
64-
{
65-
bomFileName = FileConstant.basicSBOMName + "_Bom.cdx.json";
66-
}
67-
68-
return bomFileName;
69-
}
55+
}
7056
public static string GetDefaultProjectName(CommonAppSettings appSettings)
7157
{
7258
string projectName;

0 commit comments

Comments
 (0)