build(eslint): enable rule @typescript-eslint/prefer-readonly

Author: spliffone

eslint.config.js

@@ -37,6 +37,7 @@ export const tsConfig = defineConfig({
     'vitest/prefer-each': 'error',
     'vitest/prefer-comparison-matcher': 'error',
     '@typescript-eslint/no-unused-vars': ['off'],
+    '@typescript-eslint/prefer-readonly': 'error',
     '@angular-eslint/directive-selector': [
       'error',
       {

projects/charts-ng/common/si-chart-base.component.ts

@@ -277,7 +277,7 @@ export class SiChartBaseComponent implements AfterViewInit, OnChanges, OnInit, O
   protected activeTheme: any;
   protected autoZoomUpdate = true;
 
-  private prevAxisPointer: any = {};
+  private readonly prevAxisPointer: any = {};
   private lastValidDataZoom: any = {};
   private presetDataZoomRange?: DataZoomRange;
   private dataZoomSetupDone = false;

projects/charts-ng/progress-bar/si-chart-progress-bar.component.ts

@@ -33,9 +33,9 @@ export class SiChartProgressBarComponent extends SiChartBaseComponent {
   /** Used to display the label in inline or above the progress-bar. */
   readonly labelPosition = input<string>();
 
-  private maxValue = 100;
-  private xAxisConfig: ChartXAxis = { type: 'value', max: this.maxValue };
-  private yAxis: ChartYAxis = {
+  private readonly maxValue = 100;
+  private readonly xAxisConfig: ChartXAxis = { type: 'value', max: this.maxValue };
+  private readonly yAxis: ChartYAxis = {
     type: 'category',
     data: [],
     axisLabel: {

projects/charts-ng/progress/si-chart-progress.component.ts

@@ -39,7 +39,7 @@ export class SiChartProgressComponent extends SiChartBaseComponent {
   private itemGap!: number;
 
   // base radius of an item
-  private baseRadius = 98;
+  private readonly baseRadius = 98;
 
   private sizeFactor!: number;
 

projects/dashboards-demo/src/app/app.component.ts

@@ -42,9 +42,9 @@ export class AppComponent implements OnInit {
   collapsed = false;
   theme: ThemeType = 'light';
 
-  private translate = inject(TranslateService);
-  private themeService = inject(SiThemeService);
-  private route = inject(ActivatedRoute);
+  private readonly translate = inject(TranslateService);
+  private readonly themeService = inject(SiThemeService);
+  private readonly route = inject(ActivatedRoute);
 
   constructor() {
     this.route.queryParams.subscribe(params => {

projects/dashboards-demo/src/app/components/dashboard-filters/dashboard-filters.component.ts

@@ -20,9 +20,9 @@ export class DashboardFiltersComponent implements OnInit {
   readonly days = days;
   readonly severity = severity;
 
-  private formBuilder = inject(FormBuilder);
-  private dataService = inject(DataService);
-  private destroyRef = inject(DestroyRef);
+  private readonly formBuilder = inject(FormBuilder);
+  private readonly dataService = inject(DataService);
+  private readonly destroyRef = inject(DestroyRef);
 
   ngOnInit(): void {
     const formControls = {

projects/dashboards-demo/src/app/pages/custom-catalog/custom-catalog.component.ts

@@ -56,7 +56,7 @@ export class CustomCatalogPageComponent {
     }
   ];
 
-  private widgetStore = inject<AppWidgetStorage>(SI_WIDGET_STORE);
+  private readonly widgetStore = inject<AppWidgetStorage>(SI_WIDGET_STORE);
 
   onEditableChange(editable: boolean): void {
     this.emptyText = editable ? EMPTY_TEXT_EDIT : EMPTY_TEXT;

projects/dashboards-demo/src/app/pages/routed-dashboard/routed-dashboard.component.ts

@@ -67,13 +67,13 @@ export class RoutedDashboardPageComponent implements OnInit {
 
   protected dashboardId?: string;
 
-  appStateService = inject(AppStateService);
-  private route = inject(ActivatedRoute);
+  readonly appStateService = inject(AppStateService);
+  private readonly route = inject(ActivatedRoute);
 
   protected readonly primaryActions = signal<DashboardToolbarItem[]>([]);
   protected readonly secondaryActions = signal<DashboardToolbarItem[]>([]);
-  private widgetStore = inject<AppWidgetStorage>(SI_WIDGET_STORE);
-  private destroyRef = inject(DestroyRef);
+  private readonly widgetStore = inject<AppWidgetStorage>(SI_WIDGET_STORE);
+  private readonly destroyRef = inject(DestroyRef);
 
   ngOnInit(): void {
     this.route.paramMap.pipe(takeUntilDestroyed(this.destroyRef)).subscribe(params => {

projects/dashboards-demo/src/app/widgets/charts/cartesian/cartesian.component.ts

@@ -41,7 +41,7 @@ export class CartesianComponent implements OnInit, WidgetInstance {
 
   data!: Observable<CartesianChartData>;
 
-  private dataService = inject(DataService);
+  private readonly dataService = inject(DataService);
 
   ngOnInit(): void {
     this.data = (this.dataService as any)[this.config().payload.datasourceId]();

projects/dashboards-demo/src/app/widgets/charts/circle/circle.component.ts

@@ -21,7 +21,7 @@ export class CircleComponent implements OnInit, WidgetInstance {
   readonly config = input.required<WidgetConfig>();
   data!: Observable<CircleChartSeries[]>;
 
-  private dataService = inject(DataService);
+  private readonly dataService = inject(DataService);
 
   ngOnInit(): void {
     this.data = (this.dataService as any)[this.config().payload.datasourceId]();