Skip to content

Commit 7205319

Browse files
committed
fixes
1 parent 76f6810 commit 7205319

7 files changed

Lines changed: 39 additions & 2 deletions

File tree

packages/core/src/components.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3372,7 +3372,7 @@ export namespace Components {
33723372
"ariaLabelClearIconButton"?: string;
33733373
/**
33743374
* Accessible label template for the overflow indicator chip shown in multiple mode when not all selected chips fit on a single row. The `{count}` placeholder is replaced with the number of hidden items (e.g. "3 more").
3375-
* @since 6.0.0
3375+
* @since 5.1.0
33763376
* @default '{count} more'
33773377
*/
33783378
"ariaLabelMoreItems": string;
@@ -9908,7 +9908,7 @@ declare namespace LocalJSX {
99089908
"ariaLabelClearIconButton"?: string;
99099909
/**
99109910
* Accessible label template for the overflow indicator chip shown in multiple mode when not all selected chips fit on a single row. The `{count}` placeholder is replaced with the number of hidden items (e.g. "3 more").
9911-
* @since 6.0.0
9911+
* @since 5.1.0
99129912
* @default '{count} more'
99139913
*/
99149914
"ariaLabelMoreItems"?: string;

packages/core/src/components/filter-chip/filter-chip.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
.slot-container {
3030
@include text-truncation.ellipsis;
3131
line-height: vars.$large-space;
32+
min-width: 0;
3233

3334
:host-context(.disabled) {
3435
background-color: var(--theme-color-ghost);

packages/core/src/components/select/select.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,7 @@
110110
> ix-filter-chip {
111111
margin: 0.1rem;
112112
flex-shrink: 0;
113+
max-width: 6.25rem;
113114

114115
&.chip-measuring {
115116
position: absolute;
Loading
Loading
Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
<!--
2+
SPDX-FileCopyrightText: 2024 Siemens AG
3+
4+
SPDX-License-Identifier: MIT
5+
-->
6+
7+
<!DOCTYPE html>
8+
<html lang="en">
9+
<head>
10+
<meta charset="utf-8" />
11+
<meta
12+
name="viewport"
13+
content="width=device-width, initial-scale=1.0, minimum-scale=1.0, maximum-scale=5.0"
14+
/>
15+
<title>Stencil Component Starter</title>
16+
</head>
17+
<body padding="2rem">
18+
<div style="width: 200px">
19+
<ix-select value="1" mode="multiple">
20+
<ix-select-item
21+
label="Iteeeeeeeeeeeeeeeem 1"
22+
value="1"
23+
></ix-select-item>
24+
</ix-select>
25+
</div>
26+
27+
<script src="./../../utils/test/runtime/main.ts" type="module"></script>
28+
</body>
29+
</html>

testing/visual-testing/tests/select/select.e2e.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,12 @@ regressionTest.describe('select', () => {
5353
expect(await page.screenshot({ fullPage: true })).toMatchSnapshot();
5454
});
5555

56+
regressionTest('mode-multiple-long-item-label', async ({ page }) => {
57+
await page.goto('select/mode-multiple-long-item-label');
58+
59+
expect(await page.screenshot({ fullPage: true })).toMatchSnapshot();
60+
});
61+
5662
regressionTest('overflow', async ({ page }) => {
5763
await page.goto('select/overflow');
5864
await page.locator('ix-select').locator('[data-select-dropdown]').click();

0 commit comments

Comments
 (0)