Skip to content

Commit 74d6524

Browse files
fix(core/toggle-button): accessibility consistency in toggle-button (#2586)
Co-authored-by: Daniel Leroux <daniel.leroux@siemens.com>
1 parent d1cfb47 commit 74d6524

3 files changed

Lines changed: 12 additions & 1 deletion

File tree

.changeset/eight-maps-drive.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
---
2+
"@siemens/ix": patch
3+
"@siemens/ix-angular": patch
4+
"@siemens/ix-react": patch
5+
"@siemens/ix-vue": patch
6+
---
7+
8+
Disabled buttons are now correctly inaccessible, preventing unintended interactions.

packages/core/src/components/button/base-button.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,7 @@ export const BaseButton: FunctionalComponent<BaseButtonProps> = (
167167
<button
168168
{...commonAttributes}
169169
aria-disabled={a11yBoolean(props.disabled)}
170+
disabled={props.disabled || props.loading}
170171
onClick={(e: Event) => handleOnClick(e, props)}
171172
type={props.type}
172173
>

packages/react-test-app/src/main.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -243,6 +243,7 @@ import ToastCustom from './preview-examples/toast-custom';
243243
import ToastPosition from './preview-examples/toast-position';
244244
import Toggle from './preview-examples/toggle';
245245
import toggleButtonPrimary from './preview-examples/toggle-button-primary.tsx';
246+
import ToggleButtonSecondary from './preview-examples/toggle-button-secondary';
246247
import ToggleButtonSubtlePrimary from './preview-examples/toggle-button-subtle-primary';
247248
import ToggleButtonSubtleSecondary from './preview-examples/toggle-button-subtle-secondary';
248249
import ToggleButtonSubtleTertiary from './preview-examples/toggle-button-subtle-tertiary';
@@ -454,10 +455,11 @@ const routes: IxPreviewRoutes = {
454455
'/preview/toast-custom': ToastCustom,
455456
'/preview/toast-position': ToastPosition,
456457
'/preview/toast': Toast,
457-
'/preview/toggle-button-tertiary': ToggleButtonTertiary,
458+
'/preview/toggle-button-secondary': ToggleButtonSecondary,
458459
'/preview/toggle-button-subtle-primary': ToggleButtonSubtlePrimary,
459460
'/preview/toggle-button-subtle-secondary': ToggleButtonSubtleSecondary,
460461
'/preview/toggle-button-subtle-tertiary': ToggleButtonSubtleTertiary,
462+
'/preview/toggle-button-tertiary': ToggleButtonTertiary,
461463
'/preview/toggle-checked': ToggleChecked,
462464
'/preview/toggle-custom-label': ToggleCustomLabel,
463465
'/preview/toggle-disabled': ToggleDisabled,

0 commit comments

Comments
 (0)