File tree Expand file tree Collapse file tree 2 files changed +1
-5
lines changed Expand file tree Collapse file tree 2 files changed +1
-5
lines changed Original file line number Diff line number Diff line change @@ -162,9 +162,7 @@ impl<G: PrimeGroup> CanonicalLinearRelation<G> {
162162 }
163163 }
164164
165- // Only include constraints that are non-trivial (not zero constraints)
166- // QUESTION: Should this actually be done? In the 0 = [] case, this seems to be no loss. In
167- // the error case, this precludes including an always-false OR branch.
165+ // Only include constraints that are non-trivial (not zero constraints).
168166 if rhs_terms. is_empty ( ) {
169167 if canonical_image. is_identity ( ) . into ( ) {
170168 return Ok ( ( ) ) ;
Original file line number Diff line number Diff line change @@ -133,7 +133,6 @@ mod instance_validation {
133133
134134 // The following relation is trivially invalid.
135135 // That is, we know that no witness will ever satisfy it.
136- // In this case, we're letting the prover fail and build the relation anyways.
137136 let mut linear_relation = LinearRelation :: < G > :: new ( ) ;
138137 let B_var = linear_relation. allocate_element ( ) ;
139138 let C_var = linear_relation. allocate_eq ( B_var ) ;
@@ -146,7 +145,6 @@ mod instance_validation {
146145 . contains( "trivially false constraint" ) ) ;
147146
148147 // Also in this case, we know that no witness will ever satisfy the relation.
149- // Also here, the relation is built even though the prover will never be able to give a valid proof for it.
150148 // X != B * pub_scalar + A * 3
151149 let mut linear_relation = LinearRelation :: < G > :: new ( ) ;
152150 let [ B_var , A_var ] = linear_relation. allocate_elements ( ) ;
You can’t perform that action at this time.
0 commit comments