fix: clippy warnings (#71)

Author: nougzarm

src/composition.rs

@@ -106,7 +106,7 @@ pub enum ComposedWitness<G: PrimeGroup> {
 type ComposedChallenge<G> = <SchnorrProof<G> as SigmaProtocol>::Challenge;
 
 const fn composed_challenge_size<G: PrimeGroup>() -> usize {
-    (G::Scalar::NUM_BITS as usize + 7) / 8
+    (G::Scalar::NUM_BITS as usize).div_ceil(8)
 }
 
 impl<G: PrimeGroup + ConstantTimeEq> ComposedRelation<G> {
@@ -209,11 +209,11 @@ impl<G: PrimeGroup + ConstantTimeEq> ComposedRelation<G> {
         let mut prover_states = Vec::new();
 
         for (i, w) in witnesses.iter().enumerate() {
-            let (commitment, prover_state) = instances[i].prover_commit(&w, rng)?;
+            let (commitment, prover_state) = instances[i].prover_commit(w, rng)?;
             let (simulated_commitment, simulated_challenge, simulated_response) =
                 instances[i].simulate_transcript(rng)?;
 
-            let valid_witness = instances[i].is_witness_valid(&w);
+            let valid_witness = instances[i].is_witness_valid(w);
             commitments.push(if valid_witness.unwrap_u8() == 1 {
                 commitment
             } else {
@@ -234,7 +234,7 @@ impl<G: PrimeGroup + ConstantTimeEq> ComposedRelation<G> {
         let prover_state = prover_states;
 
         if witnesses_found != 1 {
-            return Err(Error::InvalidInstanceWitnessPair);
+            Err(Error::InvalidInstanceWitnessPair)
         } else {
             Ok((
                 ComposedCommitment::Or(commitments),
@@ -262,11 +262,11 @@ impl<G: PrimeGroup + ConstantTimeEq> ComposedRelation<G> {
         ) in &prover_states
         {
             let c = G::Scalar::conditional_select(
-                &simulated_challenge,
+                simulated_challenge,
                 &G::Scalar::ZERO,
                 *valid_witness,
             );
-            witness_challenge = witness_challenge - c;
+            witness_challenge -= c;
         }
         for (
             instance,

src/linear_relation/mod.rs

@@ -139,7 +139,6 @@ impl<G: PrimeGroup> LinearMap<G> {
                 }
             })
             .collect::<Result<Vec<_>, InvalidInstance>>()
-            .into()
     }
 }
 

src/tests/test_relations.rs

@@ -305,10 +305,10 @@ fn simple_subtractions<G: PrimeGroup, R: RngCore>(
 }
 
 fn subtractions_with_shift<G: PrimeGroup, R: RngCore>(
-    mut rng: &mut R,
+    rng: &mut R,
 ) -> (CanonicalLinearRelation<G>, Vec<G::Scalar>) {
     let B = G::generator();
-    let x = G::Scalar::random(&mut rng);
+    let x = G::Scalar::random(rng);
     let X = B * (x - G::Scalar::from(2));
 
     let mut linear_relation = LinearRelation::<G>::new();
@@ -444,11 +444,10 @@ fn test_cmz_wallet_with_fee() {
 fn test_relations() {
     use group::Group;
     type G = bls12_381::G1Projective;
+    type RelationGenerator<G> =
+        Box<dyn Fn(&mut OsRng) -> (CanonicalLinearRelation<G>, Vec<<G as Group>::Scalar>)>;
 
-    let instance_generators: Vec<(
-        &str,
-        Box<dyn Fn(&mut OsRng) -> (CanonicalLinearRelation<G>, Vec<<G as Group>::Scalar>)>,
-    )> = vec![
+    let instance_generators: Vec<(&str, RelationGenerator<G>)> = vec![
         ("dlog", Box::new(discrete_logarithm)),
         ("shifted_dlog", Box::new(shifted_dlog)),
         ("dleq", Box::new(dleq)),
@@ -488,12 +487,12 @@ fn test_relations() {
         let nizk = Nizk::<SchnorrProof<G>, Shake128DuplexSponge<G>>::new(&domain_sep, protocol);
 
         // Test both proof types
-        let proof_batchable = nizk.prove_batchable(&witness, &mut OsRng).expect(&format!(
-            "Failed to create batchable proof for {relation_name}"
-        ));
-        let proof_compact = nizk.prove_compact(&witness, &mut OsRng).expect(&format!(
-            "Failed to create compact proof for {relation_name}"
-        ));
+        let proof_batchable = nizk
+            .prove_batchable(&witness, &mut OsRng)
+            .unwrap_or_else(|_| panic!("Failed to create batchable proof for {relation_name}"));
+        let proof_compact = nizk
+            .prove_compact(&witness, &mut OsRng)
+            .unwrap_or_else(|_| panic!("Failed to create compact proof for {relation_name}"));
 
         // Verify both proof types
         assert!(