refactor(modules): avoid public re-exports of all data. (#11)

Author: mmaker

src/codec/keccak_codec.rs

@@ -1,6 +1,6 @@
 //! # Keccak-based Fiat-Shamir Codec for vector tests
 //!
-//! This module implements a **Fiat-Shamir codec** using the Keccak-f[1600] permutation
+//! This module implements a **Fiat-Shamir codec** using the Keccak-f\[1600\] permutation
 //! in a duplex sponge construction
 //!
 //! It includes:
@@ -17,7 +17,7 @@
 //! - The `verifier_challenge` logic performs SHAKE-style domain separation and modulus reduction via `num-bigint`.
 //!
 //! ## Components
-//! - `KeccakPermutationState`: Low-level Keccak-f[1600] state representation
+//! - `KeccakPermutationState`: Low-level Keccak-f\[1600\] state representation
 //! - `KeccakDuplexSponge`: Duplex sponge over 200-byte state buffer
 //! - `ByteSchnorrCodec`: Fiat-Shamir codec compatible with Sage Schnorr proofs
 use crate::codec::r#trait::{Codec, DuplexSpongeInterface};

src/fiat_shamir.rs

@@ -13,7 +13,9 @@
 //! - `C`: the codec ([`Codec`] trait).
 //! - `G`: the group used for commitments and operations ([`Group`] trait).
 
-use crate::{codec::Codec, CompactProtocol, ProofError, SigmaProtocol};
+use crate::codec::Codec;
+use crate::errors::ProofError;
+use crate::traits::{CompactProtocol, SigmaProtocol};
 
 use group::{Group, GroupEncoding};
 use rand::{CryptoRng, RngCore};

src/group_serialization.rs

@@ -6,7 +6,7 @@
 use ff::PrimeField;
 use group::{Group, GroupEncoding};
 
-use crate::ProofError;
+use crate::errors::ProofError;
 
 /// Serialize a group element into a byte vector.
 ///

src/lib.rs

@@ -20,15 +20,6 @@ pub mod group_serialization;
 pub mod proof_builder;
 pub mod proof_composition;
 pub mod schnorr_protocol;
-pub mod r#trait;
-
-pub use errors::*;
-pub use fiat_shamir::*;
-pub use group_morphism::*;
-pub use group_serialization::*;
-pub use proof_builder::*;
-pub use proof_composition::*;
-pub use r#trait::*;
-pub use schnorr_protocol::*;
+pub mod traits;
 
 pub mod codec;

src/proof_builder.rs

@@ -16,7 +16,11 @@
 use group::{Group, GroupEncoding};
 use rand::{CryptoRng, RngCore};
 
-use crate::{codec::ShakeCodec, NISigmaProtocol, PointVar, ProofError, ScalarVar, SchnorrProtocol};
+use crate::codec::ShakeCodec;
+use crate::errors::ProofError;
+use crate::fiat_shamir::NISigmaProtocol;
+use crate::group_morphism::{PointVar, ScalarVar};
+use crate::schnorr_protocol::SchnorrProtocol;
 
 /// A builder that helps construct Sigma proofs for linear group relations.
 ///

src/proof_composition.rs

@@ -1,10 +1,10 @@
 use ff::{Field, PrimeField};
 use group::{Group, GroupEncoding};
 
-use crate::{
-    deserialize_scalar, serialize_scalar, CompactProtocol, ProofError, SchnorrProtocol,
-    SigmaProtocol, SigmaProtocolSimulator,
-};
+use crate::errors::ProofError;
+use crate::group_serialization::{deserialize_scalar, serialize_scalar};
+use crate::schnorr_protocol::SchnorrProtocol;
+use crate::traits::{CompactProtocol, SigmaProtocol, SigmaProtocolSimulator};
 
 #[derive(Default)]
 pub struct AndProtocol<G: Group + GroupEncoding>(pub Vec<SchnorrProtocol<G>>);

src/schnorr_protocol.rs

@@ -4,9 +4,11 @@
 //! a Sigma protocol proving different types of discrete logarithm relations (eg. Schnorr, Pedersen's commitments)
 //! through a group morphism abstraction (see Maurer09).
 
+use crate::errors::ProofError;
+use crate::group_morphism::{GroupMorphismPreimage, PointVar, ScalarVar};
 use crate::{
-    group_serialization::*, CompactProtocol, GroupMorphismPreimage, PointVar, ProofError,
-    ScalarVar, SigmaProtocol, SigmaProtocolSimulator,
+    group_serialization::*,
+    traits::{CompactProtocol, SigmaProtocol, SigmaProtocolSimulator},
 };
 
 use ff::{Field, PrimeField};
@@ -211,8 +213,8 @@ where
     /// - `data`: A byte slice containing the serialized proof.
     ///
     /// # Returns
-    /// - A tuple `(commitment, response)` where  
-    ///   * `commitment` is a vector of group elements (one per statement), and  
+    /// - A tuple `(commitment, response)` where
+    ///   * `commitment` is a vector of group elements (one per statement), and
     ///   * `response`   is a vector of scalars (one per witness).
     ///
     /// # Errors

src/trait.rs renamed to src/traits.rs

@@ -2,7 +2,7 @@
 //!
 //! This module defines the [`SigmaProtocol`] trait, a generic interface for 3-message Sigma protocols.
 
-use crate::ProofError;
+use crate::errors::ProofError;
 use rand::{CryptoRng, Rng};
 
 /// A trait defining the behavior of a generic Sigma protocol.

tests/morphism_preimage.rs

@@ -5,10 +5,9 @@ use rand::{
     {CryptoRng, Rng},
 };
 
-use sigma_rs::{
-    codec::ShakeCodec, group_morphism::msm_pr, GroupMorphismPreimage, NISigmaProtocol,
-    SchnorrProtocol,
-};
+use sigma_rs::fiat_shamir::NISigmaProtocol;
+use sigma_rs::group_morphism::{msm_pr, GroupMorphismPreimage};
+use sigma_rs::{codec::ShakeCodec, schnorr_protocol::SchnorrProtocol};
 
 type G = G1Projective;
 

tests/proof_builder.rs

@@ -2,7 +2,7 @@ use bls12_381::{G1Projective, Scalar};
 use group::ff::Field;
 
 use rand::rngs::OsRng;
-use sigma_rs::ProofBuilder;
+use sigma_rs::proof_builder::ProofBuilder;
 
 type G = G1Projective;