updated test vectors from spec and RNG

Author: vishady721

src/tests/spec/allVectors.json

@@ -1,27 +1,32 @@
 {
   "discrete_logarithm": {
+    "Ciphersuite": "sigma/OWKeccak1600+Bls12381",
     "Context": "79656c6c6f77207375626d6172696e6579656c6c6f77207375626d6172696e65",
     "Proof": "80c96c2822d816de609d4b72dd0b2a9409a3402338c977467225e7f506a60f3153a7f447450d7336c0ef15e4151349d95aab19ad1899c809b16226a60fa8abc9532bbf779d112bc4c0c4a6d2f5a95b23",
     "Statement": "TODO"
   },
   "dleq": {
+    "Ciphersuite": "sigma/OWKeccak1600+Bls12381",
     "Context": "79656c6c6f77207375626d6172696e6579656c6c6f77207375626d6172696e65",
     "Proof": "a01abd54895b7df2d476b2371e1796278a114f7dd1514e05cc1c0c07d40957268684c8887aa3f8cee33856ca325412f5859a8bb9d31747dafffcfe70acd32bcb30b45db8333cd157f561039e654e2f8314ee648604afdb4c2a4c30ae9649119259a2f6ced2950f9865565a385e99055cd11368efbb2f550f1f75a4ae80f207cd",
     "Statement": "TODO"
   },
   "pedersen_commitment": {
+    "Ciphersuite": "sigma/OWKeccak1600+Bls12381",
     "Context": "79656c6c6f77207375626d6172696e6579656c6c6f77207375626d6172696e65",
     "Proof": "91c620e60e68502ab1e0f0fa6b9f7e3225f678596da80c0e950e4149078562518ad37ed6177c71ebd6e2ca5fc32457d80b4264ea8a92bec6bbd5624af41159e00f6c65a81a25e4f148b174c3fd4f7caa163bd697e16ad7885f148b018b18dc32f68a23028d68c18140c0b71e06c6d43b",
     "Statement": "TODO"
   },
   "pedersen_commitment_dleq": {
+    "Ciphersuite": "sigma/OWKeccak1600+Bls12381",
     "Context": "79656c6c6f77207375626d6172696e6579656c6c6f77207375626d6172696e65",
-    "Proof": "8e670749a002c02e0b343a47c0194743d9164d5026ddec0a9572a742748305f83b2fc679858f2f97debd72a08ec59dc38e5d6c8cc6cb284f4012d4eb41a807d1463ad0d8976f78baff1da1fdf2ad39027e8c66e0625b15740a72fc9e866f1d106eb5822a300f6365cbc7809e81cf2c3576c10a286a14bf1107881684beba788c3cd7575ff3afaa135fb1b549621acdf7c9fe8602401dfc25d4fde441f2b17c2e",
+    "Proof": "b3e0e2f9f68405774ae13cc7271ffa66199c079a332977a0170ff134739feccc674ce0be72e236312ecf3194cfca25eb8253ccdd07c6b67dd79f3a27f214bfcb42d2b0f34432ec795ab286f099bb19ed011b0b10828e58a10d5ef8fb4f615bf815a430cc459981d82d5deea0422d44cb0ccefd96c25bb308e5d3a6661384daec2c5a50af85ae4ddccacf73e06a1c0646bb5f286a969779a84e0f382ef1074430",
     "Statement": "TODO"
   },
   "bbs_blind_commitment_computation": {
+    "Ciphersuite": "sigma/OWKeccak1600+Bls12381",
     "Context": "79656c6c6f77207375626d6172696e6579656c6c6f77207375626d6172696e65",
-    "Proof": "803d5d4fdb311967832758ae7402d03304b570f97c0756e5385a50622d0ac7b5de87fe14d15041b1564ba4893a11873043bb167cd1e1a68828e788be7ff518768d9c225d59785d6a9db3cabe9aaedf214fce23f4ec1665481b35bfd4b0d586058170e2ca22185242535ec49b173da9f12d00fa7e4a22440d1bf7cd04da48b0aca6b035a3be434cc2184036191ae61d535404fda6bed2505adb6eba56a8b8f456fe948de0a5531376fc7e726198e8be8d",
+    "Proof": "803d5d4fdb311967832758ae7402d03304b570f97c0756e5385a50622d0ac7b5de87fe14d15041b1564ba4893a1187302c2586dfcef105d3f437d2d1095be7e68b6d55a09e774bad40aeac24b34d26af4fce23f4ec1665481b35bfd4b0d586058170e2ca22185242535ec49b173da9f12d00fa7e4a22440d1bf7cd04da48b0aca6b035a3be434cc2184036191ae61d535404fda6bed2505adb6eba56a8b8f456fe948de0a5531376fc7e726198e8be8d",
     "Statement": "TODO"
   }
 }

src/tests/spec/bls12_381.rs

@@ -3,7 +3,6 @@ use ff::PrimeField;
 use group::Group;
 use hex::FromHex;
 use num_bigint::BigUint;
-use num_traits::One;
 use rand::{CryptoRng, Rng};
 use subtle::CtOption;
 
@@ -33,7 +32,7 @@ impl SInput for G1Projective {
 impl SRandom for G1Projective {
     fn randint_big(l: &BigUint, h: &BigUint, rng: &mut (impl Rng + CryptoRng)) -> BigUint {
         assert!(l <= h);
-        let range = h - l + BigUint::one();
+        let range = h - l;
         let bits = range.bits();
         #[allow(clippy::manual_div_ceil)]
         let bytes_needed = ((bits + 7) / 8) as usize;