fix: trait methods, remove underscore prefix from arguments.

Remove useless trait implementation and underscore prefix from arguments that are not used.

Author: mmaker

src/proof_composition.rs

@@ -118,24 +118,24 @@ where
         out
     }
 
-    fn deserialize_batchable(&self, data: &[u8]) -> Option<(Self::Commitment, Self::Response)> {   
+    fn deserialize_batchable(&self, data: &[u8]) -> Option<(Self::Commitment, Self::Response)> {
         if data.len() < 4 {
             return None; // not enough bytes to contain the length suffix
         }
-    
+
         // Split off the last 4 bytes as the trailer
         let (proof_data, len_bytes) = data.split_at(data.len() - 4);
         let len0 = u32::from_le_bytes(len_bytes.try_into().ok()?) as usize;
-    
+
         if proof_data.len() < len0 {
             return None; // length hint exceeds available bytes
         }
-    
+
         let (ser0, ser1) = proof_data.split_at(len0);
-    
+
         let (commitment0, response0) = self.protocol0.deserialize_batchable(ser0)?;
         let (commitment1, response1) = self.protocol1.deserialize_batchable(ser1)?;
-    
+
         Some(((commitment0, commitment1), (response0, response1)))
     }
 }
@@ -213,7 +213,7 @@ where
         let (r_index, r_witness_w) = witness;
         match r_witness_w {
             OrEnum::Left(ref r_witness) => {
-                let f_trnsc = self.protocol1.simulate_transcription(rng);
+                let f_trnsc = self.protocol1.simulate_transcript(rng);
                 let ST = OrState(f_trnsc.1, f_trnsc.2);
                 let (commit, r_pr_st) = self.protocol0.prover_commit(r_witness, rng);
                 (
@@ -222,7 +222,7 @@ where
                 )
             }
             OrEnum::Right(ref r_witness) => {
-                let f_trnsc = self.protocol0.simulate_transcription(rng);
+                let f_trnsc = self.protocol0.simulate_transcript(rng);
                 let ST = OrState(f_trnsc.1, f_trnsc.2);
                 let (commit, r_pr_st) = self.protocol1.prover_commit(r_witness, rng);
                 (

src/trait.rs

@@ -89,19 +89,15 @@ pub trait CompactProtocol: SigmaProtocol {
 
     fn serialize_compact(
         &self,
-        _commitment: &Self::Commitment,
-        _challenge: &Self::Challenge,
-        _response: &Self::Response,
-    ) -> Vec<u8> {
-        panic!("serialize_compact not implemented for this protocol")
-    }
+        commitment: &Self::Commitment,
+        challenge: &Self::Challenge,
+        response: &Self::Response,
+    ) -> Vec<u8>;
 
     fn deserialize_compact(
         &self,
-        _data: &[u8]
-    ) -> Option<(Self::Challenge, Self::Response)> {
-        panic!("deserialize_compact not implemented for this protocol")
-    }
+        data: &[u8]
+    ) -> Option<(Self::Challenge, Self::Response)>;
 }
 
 /// A trait defining the behavior of a Sigma protocol for which simulation of transcripts is necessary.
@@ -122,16 +118,16 @@ pub trait SigmaProtocolSimulator: SigmaProtocol {
     /// Panics if simulation is not implemented for this protocol.
     fn simulate_proof(
         &self,
-        _challenge: &Self::Challenge,
-        _rng: &mut (impl Rng + CryptoRng),
+        challenge: &Self::Challenge,
+        rng: &mut (impl Rng + CryptoRng),
     ) -> (Self::Commitment, Self::Response);
 
-    /// Simulates an entire protocol transcript including a random challenge.
+    /// Simulates an entire protocol transcript.
     ///
     /// # Panics
     /// Panics if simulation is not implemented for this protocol.
-    fn simulate_transcription(
+    fn simulate_transcript(
         &self,
-        _rng: &mut (impl Rng + CryptoRng),
+        rng: &mut (impl Rng + CryptoRng),
     ) -> (Self::Commitment, Self::Challenge, Self::Response);
 }

tests/proof_composition_test.rs

@@ -2,10 +2,10 @@ use curve25519_dalek::{ristretto::RistrettoPoint, scalar::Scalar};
 use rand::{rngs::OsRng, CryptoRng, Rng};
 
 use sigma_rs::{
-    OrEnum, 
-    AndProtocol, 
-    OrProtocol, 
-    SigmaProtocol, 
+    OrEnum,
+    AndProtocol,
+    OrProtocol,
+    SigmaProtocol,
     SigmaProtocolSimulator,
     ProofError,
 };
@@ -53,7 +53,7 @@ impl SigmaProtocol for SchnorrZkp {
             false => Err(ProofError::VerificationFailure),
         }
     }
-    
+
     fn serialize_batchable(
         &self,
         _commitment: &Self::Commitment,
@@ -62,7 +62,7 @@ impl SigmaProtocol for SchnorrZkp {
     ) -> Vec<u8> {
         todo!()
     }
-    
+
     fn deserialize_batchable(&self, _data: &[u8]) -> Option<(Self::Commitment, Self::Response)> {
         todo!()
     }
@@ -80,7 +80,7 @@ impl SigmaProtocolSimulator for SchnorrZkp {
         (R, z)
     }
 
-    fn simulate_transcription(
+    fn simulate_transcript(
         &self,
         rng: &mut (impl Rng + CryptoRng),
     ) -> (Self::Commitment, Self::Challenge, Self::Response) {