Skip to content

Commit de5d06d

Browse files
committed
Finalizing tests so that test vectors match Sage outputs
1 parent 37f7000 commit de5d06d

File tree

7 files changed

+99
-137
lines changed

7 files changed

+99
-137
lines changed

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ sha2 = "0.10"
3636
subtle = "2.6.1"
3737
num-bigint = "0.4.6"
3838
num-traits = "0.2.19"
39-
tiny-keccak = { version = "2.0.2", features = ["keccak"] }
39+
tiny-keccak = { version = "2.0.2", features = ["fips202"] }
4040
bls12_381 = "0.8.0"
4141

4242
[dev-dependencies]

src/toolbox/sigma/transcript/keccak_transcript.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -135,11 +135,11 @@ impl DuplexSpongeInterface for KeccakDuplexSponge {
135135
}
136136

137137
let chunk_size = usize::min(self.rate - self.squeeze_index, length);
138-
output.extend_from_slice(
139-
&self.state.state[self.squeeze_index..self.squeeze_index + chunk_size],
140-
);
141138
self.squeeze_index += chunk_size;
142139
length -= chunk_size;
140+
output.extend_from_slice(
141+
&self.state.state[self.squeeze_index..self.squeeze_index + chunk_size]
142+
);
143143
}
144144

145145
output

tests/spec/bls12_381.rs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,4 +65,10 @@ impl SRandom for G1Projective {
6565
}
6666
G1Projective::scalar_from_hex_be(&hex_string).unwrap()
6767
}
68+
69+
fn prandom(
70+
rng: &mut (impl Rng + CryptoRng)
71+
) -> Self {
72+
Self::generator() * Self::srandom(rng)
73+
}
6874
}

tests/spec/custom_schnorr_proof.rs

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,9 @@ where
8383
}
8484

8585
for response in response.iter().take(scalar_nb) {
86-
bytes.extend_from_slice(&G::serialize_scalar(response));
86+
let mut scalar_bytes = G::serialize_scalar(response);
87+
scalar_bytes.reverse();
88+
bytes.extend_from_slice(&scalar_bytes);
8789
}
8890
bytes
8991
}
@@ -119,8 +121,9 @@ where
119121
let start = point_nb * point_size + i * scalar_size;
120122
let end = start + scalar_size;
121123

122-
let slice = &data[start..end];
123-
let scalar = G::deserialize_scalar(slice)?;
124+
let mut slice = data[start..end].to_vec();
125+
slice.reverse();
126+
let scalar = G::deserialize_scalar(&slice)?;
124127
responses.push(scalar);
125128
}
126129

tests/spec/low_level_tests.rs

Lines changed: 0 additions & 61 deletions
This file was deleted.

tests/spec/random.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,5 +18,9 @@ pub trait SRandom: Group {
1818
fn srandom(
1919
rng: &mut (impl Rng + CryptoRng)
2020
) -> Self::Scalar;
21+
22+
fn prandom(
23+
rng: &mut (impl Rng + CryptoRng)
24+
) -> Self;
2125
}
2226

0 commit comments

Comments
 (0)