improved error messages (#201)

Author: scott-cotton

internal/config/local.go

@@ -40,19 +40,24 @@ func (l *Local) InitLocalProxyConfig() error {
 
 func (l *Local) InitLocalConfig() error {
 	if err := l.InitLocalProxyConfig(); err != nil {
+		panic(err)
 		return err
 	}
 
 	type Tmp struct {
 		Local *config.Config `json:"local"`
 	}
 	localConfig := &Tmp{}
-	d, e := os.ReadFile(viper.ConfigFileUsed())
+	configFile := viper.ConfigFileUsed()
+	if configFile == "" {
+		return errors.New("config file needed for local configuration, see https://www.signadot.com/docs/getting-started/installation/signadot-cli")
+	}
+	d, e := os.ReadFile(configFile)
 	if e != nil {
-		return e
+		return fmt.Errorf("error reading config file %q: %w", configFile, e)
 	}
 	if e := yaml.Unmarshal(d, localConfig); e != nil {
-		return e
+		return fmt.Errorf("error unmarshalling config file %q: %w", configFile, e)
 	}
 	if localConfig.Local == nil {
 		return fmt.Errorf("no local section in %s", viper.ConfigFileUsed())

internal/config/locald.go

@@ -41,7 +41,7 @@ func (ld *LocalDaemon) InitLocalDaemon() error {
 	if ld.ConnectInvocationConfigFile != "" {
 		ciBytes, err = os.ReadFile(ld.ConnectInvocationConfigFile)
 		if err != nil {
-			return err
+			return fmt.Errorf("error reading connect invocation config file %q: %w", ld.ConnectInvocationConfigFile, err)
 		}
 	} else {
 		ciBytes = []byte(os.Getenv("SIGNADOT_LOCAL_CONNECT_INVOCATION_CONFIG"))

internal/utils/system/system.go

@@ -17,7 +17,7 @@ import (
 func GetSignadotDir() (string, error) {
 	homeDir, err := os.UserHomeDir()
 	if err != nil {
-		return "", err
+		return "", fmt.Errorf("error getting user home dir: %w", err)
 	}
 	return filepath.Join(homeDir, ".signadot"), nil
 }
@@ -76,7 +76,10 @@ func OpenBrowser(url string) error {
 	default: // "linux", "freebsd", "openbsd", "netbsd"
 		cmd = exec.Command("xdg-open", url)
 	}
-	return cmd.Start()
+	if err := cmd.Start(); err != nil {
+		return fmt.Errorf("unable to open url %q: %w", url, err)
+	}
+	return nil
 }
 
 func GetSandboxesDir() (string, error) {