Fetch all PFS queries in backgroud without order by

Author: svaroqui

cluster/srv.go

@@ -172,6 +172,7 @@ type ServerMonitor struct {
 	BinaryLogFiles              map[string]uint              `json:"binaryLogFiles"`
 	MaxSlowQueryTimestamp       int64                        `json:"maxSlowQueryTimestamp"`
 	IsInSlowQueryCapture        bool
+	IsInPFSQueryCapture         bool
 }
 
 type serverList []*ServerMonitor
@@ -728,20 +729,14 @@ func (server *ServerMonitor) Refresh() error {
 			server.EngineInnoDB, logs, err = dbhelper.GetEngineInnoDBVariables(server.Conn)
 			server.ClusterGroup.LogSQL(logs, err, server.URL, "Monitor", LvlDbg, "Could not get engine innodb status %s %s", server.URL, err)
 		}
-		if server.ClusterGroup.Conf.MonitorPFS && server.HavePFSSlowQueryLog && server.HavePFS {
-			// GET PFS query digest
-			server.PFSQueries, logs, err = dbhelper.GetQueries(server.Conn)
-			server.ClusterGroup.LogSQL(logs, err, server.URL, "Monitor", LvlDbg, "Could not get queries %s %s", server.URL, err)
-		}
+		go server.GetPFSQueries()
+		go server.GetSlowLogTable()
 		if server.HaveDiskMonitor {
 			server.Disks, logs, err = dbhelper.GetDisks(server.Conn, server.DBVersion)
 		}
 		if server.ClusterGroup.Conf.MonitorScheduler {
 			server.CheckDisks()
 		}
-		if server.HasLogsInSystemTables() {
-			go server.GetSlowLogTable()
-		}
 
 	} // End not PG
 

cluster/srv_get.go

@@ -384,6 +384,23 @@ func (server *ServerMonitor) GetErrorLog() s18log.HttpLog {
 	return server.ErrorLog
 }
 
+func (server *ServerMonitor) GetPFSQueries() {
+	if !(server.ClusterGroup.Conf.MonitorPFS && server.HavePFSSlowQueryLog && server.HavePFS) {
+		return
+	}
+	if server.IsInPFSQueryCapture {
+		return
+	}
+	server.IsInPFSQueryCapture = true
+	defer func() { server.IsInPFSQueryCapture = false }()
+
+	var err error
+	logs := ""
+	// GET PFS query digest
+	server.PFSQueries, logs, err = dbhelper.GetQueries(server.Conn)
+	server.ClusterGroup.LogSQL(logs, err, server.URL, "Monitor", LvlDbg, "Could not get queries %s %s", server.URL, err)
+}
+
 func (server *ServerMonitor) GetPFSStatements() []dbhelper.PFSQuery {
 	var rows []dbhelper.PFSQuery
 	for _, v := range server.PFSQueries {

utils/dbhelper/dbhelper.go

@@ -1551,9 +1551,11 @@ func GetQueries(db *sqlx.DB) (map[string]PFSQuery, string, error) {
 	A.SUM_ROWS_EXAMINED AS rows_scanned,
 	round(A.sum_timer_wait/1000000000000, 6) as value
 	FROM performance_schema.events_statements_summary_by_digest A
-	WHERE A.digest_text is not null
-	ORDER BY A.sum_timer_wait desc
-	LIMIT 50`
+	WHERE A.digest_text is not null`
+
+	// Do not order as it's eavy fot temporary directory
+	//ORDER BY A.sum_timer_wait desc
+	//LIMIT 50`
 
 	rows, err := db.Queryx(query)
 	if err != nil {