Fixed MySQLmultiple GTID failover rejoin, Can failed reading 1+n server_id as GTID_EXECUTED need to be trim from ciariage return and space from the putput of show slave status

Author: svaroqui

cluster/cluster_fail.go

@@ -168,7 +168,7 @@ func (cluster *Cluster) MasterFailover(fail bool) bool {
 		}
 	} else if cluster.master.DBVersion.IsMySQLOrPerconaGreater57() && cluster.master.HasGTIDReplication() {
 		cluster.LogPrintf(LvlInfo, "MySQL GTID saving crash info for replication ExexecutedGtidSet %s", ms.ExecutedGtidSet.String)
-		crash.FailoverIOGtid = gtid.NewMySQLList(strings.ToUpper(ms.ExecutedGtidSet.String))
+		crash.FailoverIOGtid = gtid.NewMySQLList(strings.ToUpper(ms.ExecutedGtidSet.String), cluster.GetCrcTable())
 	}
 	cluster.master.FailoverSemiSyncSlaveStatus = cluster.master.SemiSyncSlaveStatus
 	crash.FailoverSemiSyncSlaveStatus = cluster.master.SemiSyncSlaveStatus
@@ -1206,7 +1206,7 @@ func (cluster *Cluster) VMasterFailover(fail bool) bool {
 				crash.FailoverIOGtid = gtid.NewList(ms.GtidIOPos.String)
 			}
 		} else if cluster.master.DBVersion.IsMySQLOrPerconaGreater57() && cluster.master.HasGTIDReplication() {
-			crash.FailoverIOGtid = gtid.NewMySQLList(strings.ToUpper(ms.ExecutedGtidSet.String))
+			crash.FailoverIOGtid = gtid.NewMySQLList(strings.ToUpper(ms.ExecutedGtidSet.String), cluster.GetCrcTable())
 		}
 		cluster.master.FailoverSemiSyncSlaveStatus = cluster.master.SemiSyncSlaveStatus
 		crash.FailoverSemiSyncSlaveStatus = cluster.master.SemiSyncSlaveStatus

cluster/cluster_get.go

@@ -10,6 +10,7 @@ import (
 	"encoding/json"
 	"errors"
 	"fmt"
+	"hash/crc64"
 	"io/ioutil"
 	"regexp"
 	"sort"
@@ -25,6 +26,10 @@ import (
 	"github.com/signal18/replication-manager/utils/state"
 )
 
+func (cluster *Cluster) GetCrcTable() *crc64.Table {
+	return cluster.crcTable
+}
+
 func (cluster *Cluster) getDumpParameter() string {
 	dump_param := cluster.Conf.BackupMysqldumpOptions
 	if cluster.master != nil {

cluster/srv.go

@@ -166,7 +166,6 @@ type ServerMonitor struct {
 	Datadir                     string                       `json:"datadir"`
 	SlapOSDatadir               string                       `json:"slaposDatadir"`
 	PostgressDB                 string                       `json:"postgressDB"`
-	CrcTable                    *crc64.Table                 `json:"-"`
 	TLSConfigUsed               string                       `json:"tlsConfigUsed"` //used to track TLS config during key rotation
 	SSTPort                     string                       `json:"sstPort"`       //used to send data to dbjobs
 	Agent                       string                       `json:"agent"`         //used to provision service in orchestrator
@@ -229,10 +228,9 @@ func (cluster *Cluster) newServerMonitor(url string, user string, pass string, c
 		}
 		url = server.Name + server.Domain + ":3306"
 	}
-	server.CrcTable = crc64.MakeTable(crc64.ECMA)
 	var sid uint64
 	//will be overide in Refresh with show variables server_id, used for provisionning configurator for server_id
-	sid, err = strconv.ParseUint(strconv.FormatUint(crc64.Checksum([]byte(server.Name+server.Port), server.CrcTable), 10), 10, 64)
+	sid, err = strconv.ParseUint(strconv.FormatUint(crc64.Checksum([]byte(server.Name+server.Port), server.GetCluster().GetCrcTable()), 10), 10, 64)
 	server.ServerID = sid
 	server.Id = fmt.Sprintf("%s%d", "db", sid)
 
@@ -629,11 +627,12 @@ func (server *ServerMonitor) Refresh() error {
 				}
 
 			} else {
-				server.GTIDBinlogPos = gtid.NewMySQLList(server.Variables["GTID_EXECUTED"])
+				server.GTIDBinlogPos = gtid.NewMySQLList(server.Variables["GTID_EXECUTED"], server.GetCluster().GetCrcTable())
 				server.GTIDExecuted = server.Variables["GTID_EXECUTED"]
-				server.CurrentGtid = gtid.NewMySQLList(server.Variables["GTID_EXECUTED"])
+				server.CurrentGtid = server.GTIDBinlogPos
 				server.SlaveGtid = gtid.NewList(server.Variables["GTID_SLAVE_POS"])
-				server.HashUUID = crc64.Checksum([]byte(strings.ToUpper(server.Variables["SERVER_UUID"])), server.CrcTable)
+				server.HashUUID = crc64.Checksum([]byte(strings.ToUpper(server.Variables["SERVER_UUID"])), server.GetCluster().GetCrcTable())
+				//		fmt.Fprintf(os.Stdout, "gniac2 "+strings.ToUpper(server.Variables["SERVER_UUID"])+" "+strconv.FormatUint(server.HashUUID, 10))
 			}
 
 			var sid uint64
@@ -769,7 +768,7 @@ func (server *ServerMonitor) Refresh() error {
 		if server.DBVersion.IsPPostgreSQL() {
 			//PostgresQL as no server_id concept mimic via internal server id for topology detection
 			var sid uint64
-			sid, err = strconv.ParseUint(strconv.FormatUint(crc64.Checksum([]byte(server.SlaveStatus.MasterHost.String+server.SlaveStatus.MasterPort.String), server.ClusterGroup.crcTable), 10), 10, 64)
+			sid, err = strconv.ParseUint(strconv.FormatUint(crc64.Checksum([]byte(server.SlaveStatus.MasterHost.String+server.SlaveStatus.MasterPort.String), server.ClusterGroup.GetCrcTable()), 10), 10, 64)
 			if err != nil {
 				server.ClusterGroup.LogPrintf(LvlWarn, "PG Could not assign server_id s", err)
 			}

cluster/srv_get.go

@@ -38,7 +38,7 @@ func (server *ServerMonitor) GetUniversalGtidServerID() uint64 {
 	}
 	if server.DBVersion.IsMySQLOrPerconaGreater57() {
 		server.ClusterGroup.LogPrintf("INFO", " %s %s", server.Variables["SERVER_UUID"], server.URL)
-		return crc64.Checksum([]byte(strings.ToUpper(server.Variables["SERVER_UUID"])), server.CrcTable)
+		return crc64.Checksum([]byte(strings.ToUpper(server.Variables["SERVER_UUID"])), server.GetCluster().GetCrcTable())
 
 	}
 	return 0

utils/gtid/gtid.go

@@ -12,6 +12,7 @@ package gtid
 import (
 	"fmt"
 	"hash/crc64"
+	"regexp"
 	"sort"
 	"strconv"
 	"strings"
@@ -100,14 +101,18 @@ func NewList(s string) *List {
 	return gl
 }
 
-func NewMySQLList(s string) *List {
+func NewMySQLList(s string, crcTable *crc64.Table) *List {
 	gl := new(List)
 	if s == "" {
 		return gl
 	}
+
+	var re = regexp.MustCompile(`\r\n|[\r\n\v\f\x{0085}\x{2028}\x{2029}]`)
+
+	s = re.ReplaceAllString(s, "")
 	l := strings.Split(strings.ReplaceAll(s, " ", ""), ",")
 	for _, g := range l {
-		gtid := NewMySQLGtid(g)
+		gtid := NewMySQLGtid(g, crcTable)
 		*gl = append(*gl, *gtid)
 	}
 	return gl
@@ -123,10 +128,9 @@ func NewGtid(s string) *Gtid {
 	return g
 }
 
-func NewMySQLGtid(s string) *Gtid {
+func NewMySQLGtid(s string, crcTable *crc64.Table) *Gtid {
 	g := new(Gtid)
 	f := strings.Split(s, ":")
-	crcTable := crc64.MakeTable(crc64.ECMA)
 	seq := "1"
 	if strings.Contains(f[1], "-") {
 		e := strings.Split(f[1], "-")
@@ -138,7 +142,7 @@ func NewMySQLGtid(s string) *Gtid {
 
 	g.ServerID = crc64.Checksum([]byte(strings.ToUpper(f[0])), crcTable)
 	g.SeqNo, _ = strconv.ParseUint(seq, 10, 64)
-	//	fmt.Fprintf(os.Stdout, "gniac new MySQL GTID : "+f[0]+" "+strconv.FormatUint(g.ServerID, 10))
+	//fmt.Fprintf(os.Stdout, "gniac new MySQL GTID : "+f[0]+" "+strconv.FormatUint(g.ServerID, 10))
 
 	return g
 }