Fixing replication-manager-cli not starting caused by OS User code in flags

Author: svaroqui

clients/client_cmd.go

@@ -19,9 +19,8 @@ import (
 	"net/http"
 	"net/url"
 	"os"
-	"syscall"
-
 	"strings"
+	"syscall"
 	"time"
 
 	termbox "github.com/nsf/termbox-go"
@@ -261,7 +260,9 @@ func initStatusFlags(cmd *cobra.Command) {
 }
 
 func initConfiguratorFlags(cmd *cobra.Command) {
-	initServerApiFlags(configuratorCmd)
+//	initServerApiFlags(configuratorCmd)
+	RepMan = new(server.ReplicationManager)
+	RepMan.InitUser()
 	RepMan.AddFlags(configuratorCmd.Flags(), &conf)
 	v := viper.GetViper()
 	v.SetConfigType("toml")

clients/client_configurator.go

@@ -61,14 +61,15 @@ var configuratorCmd = &cobra.Command{
 	Short: "Config generator",
 	Long:  `Config generator produce tar.gz for databases and proxies based on ressource and tags description`,
 	Run: func(cmd *cobra.Command, args []string) {
-		conf.WithEmbed = WithEmbed
-		RepMan = new(server.ReplicationManager)
+		conf.WithEmbed = "ON"
+
 		RepMan.SetDefaultFlags(viper.GetViper())
 		conf.HttpServ = false
 		conf.ApiServ = false
+		conf.GraphiteEmbedded = false
 		RepMan.InitConfig(conf, false)
 		go RepMan.Run()
-		time.Sleep(2 * time.Second)
+		time.Sleep(3 * time.Second)
 		cluster := RepMan.Clusters[RepMan.ClusterList[0]]
 
 		if cluster == nil {

server/server.go

@@ -271,7 +271,7 @@ func (repman *ReplicationManager) AddFlags(flags *pflag.FlagSet, conf *config.Co
 	flag.StringVar(&configPath, "config", "", "help message")
 	flag.Parse()
 
-	if usr == "" {
+	if usr == "" && repman != nil {
 		usr = repman.OsUser.Name
 	}
 	flags.StringVar(&conf.MonitoringSystemUser, "user", "", "OS User for running repman")
@@ -1081,6 +1081,8 @@ func (repman *ReplicationManager) initFS(conf config.Config) error {
 	//test si y'a  un repertoire ./.replication-manager/config.toml sinon on le créer depuis embed
 	//test y'a  un repertoire ./.replication-manager/data sinon on le créer
 	//test y'a  un repertoire ./.replication-manager/share sinon on le créer
+	//repman.LogModulePrintf(repman.Conf.Verbose, config.ConstLogModGeneral, config.LvlInfo, "Embeded run config dir : %s", conf.ConfDir)
+
 	if conf.ConfDirBackup == "" {
 		repman.Logrus.Fatalf("Monitoring config backup directory not defined")
 	}
@@ -1097,6 +1099,7 @@ func (repman *ReplicationManager) initFS(conf config.Config) error {
 			os.MkdirAll(conf.BaseDir+"/data", os.ModePerm)
 			os.MkdirAll(conf.BaseDir+"/share", os.ModePerm)
 		}
+		repman.LogModulePrintf(repman.Conf.Verbose, config.ConstLogModGeneral, config.LvlInfo, "Embeded run config dir : %s", conf.ConfDir)
 
 		if _, err := os.Stat(conf.ConfDir + "/config.toml"); os.IsNotExist(err) {