ProxySQL restart can lost Servers and Users if replication-manager stopped

Author: svaroqui

cluster/prx_proxysql.go

@@ -415,24 +415,29 @@ func (proxy *ProxySQLProxy) Refresh() error {
 					}
 				}
 			}
-
+			changedUser := false
 			for _, user := range uniUsers {
 				if _, ok := myprxusermap[user.User+":"+user.Password]; !ok {
 					cluster.LogPrintf(LvlInfo, "Add ProxySQL user %s ", user.User)
-
 					err := psql.AddUser(user.User, user.Password)
 					if err != nil {
 						cluster.sme.AddState("ERR00054", state.State{ErrType: "WARNING", ErrDesc: fmt.Sprintf(clusterError["ERR00054"], err), ErrFrom: "MON", ServerUrl: proxy.Name})
-
+					} else {
+						changedUser = true
 					}
 				}
 			}
+			if changedUser {
+				psql.SaveMySQLUsersToDisk()
+			}
 		}
 	}
 	if updated {
 		err = psql.LoadServersToRuntime()
 		if err != nil {
 			cluster.LogPrintf(LvlErr, "ProxySQL could not load servers to runtime (%s)", err)
+		} else {
+			err = psql.SaveServersToDisk()
 		}
 	}
 	proxy.QueryRules, err = psql.GetQueryRulesRuntime()

router/proxysql/proxysql.go

@@ -344,3 +344,8 @@ func (psql *ProxySQL) SaveMySQLVariablesToDisk() error {
 	_, err := psql.Connection.Exec("SAVE MYSQL VARIABLES TO DISK")
 	return err
 }
+
+func (psql *ProxySQL) SaveMySQLUsersToDisk() error {
+	_, err := psql.Connection.Exec("SAVE MYSQL USERS TO DISK")
+	return err
+}