Add additional null check for app store's APIException#getApiError

eager-signal · ravi-signal · commit ac23b8e79e0f · 2026-03-12T16:36:32.000-05:00
diff --git a/service/src/main/java/org/whispersystems/textsecuregcm/subscriptions/AppleAppStoreClient.java b/service/src/main/java/org/whispersystems/textsecuregcm/subscriptions/AppleAppStoreClient.java
@@ -184,7 +184,7 @@ private static Set<InputStream> decodeRootCerts(final List<String> rootCerts) {
   private static boolean shouldRetry(Throwable e) {
     return e instanceof APIException apiException && switch (apiException.getApiError()) {
       case ORIGINAL_TRANSACTION_ID_NOT_FOUND_RETRYABLE, GENERAL_INTERNAL_RETRYABLE, APP_NOT_FOUND_RETRYABLE -> true;
-      default -> false;
+      case null, default -> false;
     };
   }
 

Original file line number	Diff line number	Diff line change
`@@ -184,7 +184,7 @@ private static Set<InputStream> decodeRootCerts(final List<String> rootCerts) {`
`184`	`184`	`private static boolean shouldRetry(Throwable e) {`
`185`	`185`	`return e instanceof APIException apiException && switch (apiException.getApiError()) {`
`186`	`186`	`case ORIGINAL_TRANSACTION_ID_NOT_FOUND_RETRYABLE, GENERAL_INTERNAL_RETRYABLE, APP_NOT_FOUND_RETRYABLE -> true;`
`187`		`- default -> false;`
	`187`	`+ case null, default -> false;`
`188`	`188`	`};`
`189`	`189`	`}`
`190`	`190`