Dropping `phonenumbers` dependency

[TabError]

Any thoughts about dropping the phonenumbers dependency?

I saw it's only used in one place. And there it's only used for simple string manipulation. (correct me if i'm wrong)

• docs
• source code

On the other hand it's 22MB. That's more than half of the overal dependencies. And that's with redis included.

[TabError]

I had a brief look at the source code (and added the link in the initial post).

So the function used seems to make use of all the shipped data of country and region codes etc, iiuc.

The Question remains: do we really need this. As stated in the docs it cannot tell whether number exists or not. So we need to catch failure anyway. Proposal: write a simple functions which checks for digit strings, (starting with '+' or '00' etc). This can even be a simple regex. And remove the phonenumbers package.

I didn't dive into our (the signalbot) code base so it would be nice to know what kind of logic actually depends on this test right now.

[Gara-Dorta]

I think 22Mb is very little to worry about in today's systems, even on small embedded device like a raspberry pi. There is a little version of the library that does the downloading on the fly, I'd be happy to switch to that instead. Would you like to make a PR for it? https://pypi.org/project/phonenumberslite/

[Gara-Dorta]

There are some issues with installing this version of the library, parking this until it is solved upstream daviddrysdale/python-phonenumbers#307