Skip to content

Commit 0ab49a5

Browse files
committed
fixes
1 parent 6461423 commit 0ab49a5

File tree

5 files changed

+6
-5
lines changed

5 files changed

+6
-5
lines changed

.chloggen/openshift-resource-detection.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ component: agent, clusterReceiver, gateway
55
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
66
note: Add OpenShift resource detection support using the openshift and ec2 detectors
77
# One or more tracking issues related to the change
8-
issues: []
8+
issues: [2330]
99
# (Optional) One or more lines of additional information to render under the primary note.
1010
# These lines will be padded with 2 spaces and then inserted directly into the document.
1111
# Use pipe (|) for multiline entries.

functional_tests/functional/testdata/expected_aks_values/expected_resource_attributes_agent.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ resourceMetrics:
66
stringValue: abcd
77
- key: cloud.platform
88
value:
9-
stringValue: azure.aks
9+
stringValue: azure_aks
1010
- key: cloud.provider
1111
value:
1212
stringValue: abcd

functional_tests/functional/testdata/expected_aks_values/expected_resource_attributes_cluster_receiver.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ resourceMetrics:
66
stringValue: abcd
77
- key: cloud.platform
88
value:
9-
stringValue: azure.aks
9+
stringValue: azure_aks
1010
- key: cloud.provider
1111
value:
1212
stringValue: abcd

functional_tests/functional/testdata/values/rosa_upgrade_from_previous_release_values.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
cloudProvider: aws
22
distribution: openshift
3+
clusterName: rosa-test-htcpw
34
environment: dev
45
splunkObservability:
56
realm: us0

helm-charts/splunk-otel-collector/templates/config/_common.tpl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ resourcedetection:
7474
{{- if eq .Values.cloudProvider "azure" }}
7575
- azure
7676
{{- end }}
77-
{{- if or (eq (include "splunk-otel-collector.isNonEKSonAWS" .) "true") (and (eq .Values.distribution "openshift") (eq .Values.cloudProvider "aws")) }}
77+
{{- if eq (include "splunk-otel-collector.isNonEKSonAWS" .) "true" }}
7878
- ec2
7979
{{- end }}
8080
# The `system` detector goes last so it can't preclude cloud detectors from setting host/os info.
@@ -120,7 +120,7 @@ resourcedetection:
120120
cloud.region:
121121
enabled: true
122122
{{- end }}
123-
{{- if or (eq (include "splunk-otel-collector.isNonEKSonAWS" .) "true") (and (eq .Values.distribution "openshift") (eq .Values.cloudProvider "aws")) }}
123+
{{- if eq (include "splunk-otel-collector.isNonEKSonAWS" .) "true" }}
124124
ec2:
125125
resource_attributes:
126126
host.id:

0 commit comments

Comments
 (0)