Skip to content

Commit d7b6c3d

Browse files
fix pod metrics annotations (#1977)
* fix metrics pod annotations, add integration tests with both namespace and pod annotations * rework k8sattributes/metrics * update CHANGELOG note
1 parent 891cad9 commit d7b6c3d

File tree

23 files changed

+205
-60
lines changed

23 files changed

+205
-60
lines changed
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
2+
change_type: bug_fix
3+
# The name of the component, or a single word describing the area of concern, (e.g. agent, clusterReceiver, gateway, operator, chart, other)
4+
component: chart
5+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
6+
note: Fix per-pod configuration of 'metricsIndex' and 'sourcetype' config for Splunk Platform metrics via annotations
7+
# One or more tracking issues related to the change
8+
issues: [1977]
9+
# (Optional) One or more lines of additional information to render under the primary note.
10+
# These lines will be padded with 2 spaces and then inserted directly into the document.
11+
# Use pipe (|) for multiline entries.
12+
subtext:

ci_scripts/k8s-splunk.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,12 @@ data:
4646
homePath: $SPLUNK_DB/test_metrics/db
4747
maxTotalDataSizeMB: 512000
4848
thawedPath: $SPLUNK_DB/test_metrics/thaweddb
49+
test_metrics_annotation:
50+
coldPath: $SPLUNK_DB/test_metrics_annotation/colddb
51+
datatype: metric
52+
homePath: $SPLUNK_DB/test_metrics_annotation/db
53+
maxTotalDataSizeMB: 512000
54+
thawedPath: $SPLUNK_DB/test_metrics_annotation/thaweddb
4955
---
5056
apiVersion: v1
5157
kind: Pod

examples/disable-persistence-queue-traces/rendered_manifests/configmap-agent.yaml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -183,18 +183,17 @@ data:
183183
filter:
184184
node_from_env_var: K8S_NODE_NAME
185185
pod_association:
186-
- sources:
187-
- from: resource_attribute
188-
name: k8s.node.name
189186
- sources:
190187
- from: resource_attribute
191188
name: k8s.pod.uid
192189
- sources:
193190
- from: resource_attribute
194-
name: k8s.pod.ip
191+
name: k8s.namespace.name
192+
- from: resource_attribute
193+
name: k8s.pod.name
195194
- sources:
196195
- from: resource_attribute
197-
name: ip
196+
name: k8s.pod.ip
198197
- sources:
199198
- from: connection
200199
memory_limiter:

examples/disable-persistence-queue-traces/rendered_manifests/configmap-cluster-receiver.yaml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -132,18 +132,17 @@ data:
132132
filter:
133133
node_from_env_var: K8S_NODE_NAME
134134
pod_association:
135-
- sources:
136-
- from: resource_attribute
137-
name: k8s.node.name
138135
- sources:
139136
- from: resource_attribute
140137
name: k8s.pod.uid
141138
- sources:
142139
- from: resource_attribute
143-
name: k8s.pod.ip
140+
name: k8s.namespace.name
141+
- from: resource_attribute
142+
name: k8s.pod.name
144143
- sources:
145144
- from: resource_attribute
146-
name: ip
145+
name: k8s.pod.ip
147146
- sources:
148147
- from: connection
149148
memory_limiter:

examples/disable-persistence-queue-traces/rendered_manifests/daemonset.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ spec:
3232
component: otel-collector-agent
3333
release: default
3434
annotations:
35-
checksum/config: 059f577d9797aed9a5dacdf64b59877cb8c69ea52dbc3c9599321e55d13d92fc
35+
checksum/config: dd3c0878d50994e2e84f458240f9f99f16783f827015ddc2f4b5d21bf4f8220e
3636
kubectl.kubernetes.io/default-container: otel-collector
3737
spec:
3838
hostNetwork: true

examples/disable-persistence-queue-traces/rendered_manifests/deployment-cluster-receiver.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ spec:
3131
component: otel-k8s-cluster-receiver
3232
release: default
3333
annotations:
34-
checksum/config: 1298c6b84710112199e140eea2d0434691e311f9b080d275d833e53655b40187
34+
checksum/config: 694025094891807930f62008e82432b8df8d0d6f867c53510b85f3b57e669df9
3535
spec:
3636
serviceAccountName: default-splunk-otel-collector
3737
nodeSelector:

examples/enable-persistence-queue/rendered_manifests/configmap-agent.yaml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -183,18 +183,17 @@ data:
183183
filter:
184184
node_from_env_var: K8S_NODE_NAME
185185
pod_association:
186-
- sources:
187-
- from: resource_attribute
188-
name: k8s.node.name
189186
- sources:
190187
- from: resource_attribute
191188
name: k8s.pod.uid
192189
- sources:
193190
- from: resource_attribute
194-
name: k8s.pod.ip
191+
name: k8s.namespace.name
192+
- from: resource_attribute
193+
name: k8s.pod.name
195194
- sources:
196195
- from: resource_attribute
197-
name: ip
196+
name: k8s.pod.ip
198197
- sources:
199198
- from: connection
200199
memory_limiter:

examples/enable-persistence-queue/rendered_manifests/configmap-cluster-receiver.yaml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -132,18 +132,17 @@ data:
132132
filter:
133133
node_from_env_var: K8S_NODE_NAME
134134
pod_association:
135-
- sources:
136-
- from: resource_attribute
137-
name: k8s.node.name
138135
- sources:
139136
- from: resource_attribute
140137
name: k8s.pod.uid
141138
- sources:
142139
- from: resource_attribute
143-
name: k8s.pod.ip
140+
name: k8s.namespace.name
141+
- from: resource_attribute
142+
name: k8s.pod.name
144143
- sources:
145144
- from: resource_attribute
146-
name: ip
145+
name: k8s.pod.ip
147146
- sources:
148147
- from: connection
149148
memory_limiter:

examples/enable-persistence-queue/rendered_manifests/daemonset.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ spec:
3232
component: otel-collector-agent
3333
release: default
3434
annotations:
35-
checksum/config: d544513bc2209474427c49ec73cc5f053c1feb32c4879a2f2f8558cda472bd0a
35+
checksum/config: a99138ec442323b8f5a2b3a7fd84f55dfed26b8e3823b88f94ab2237353307fe
3636
kubectl.kubernetes.io/default-container: otel-collector
3737
spec:
3838
hostNetwork: true

examples/enable-persistence-queue/rendered_manifests/deployment-cluster-receiver.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ spec:
3131
component: otel-k8s-cluster-receiver
3232
release: default
3333
annotations:
34-
checksum/config: 1298c6b84710112199e140eea2d0434691e311f9b080d275d833e53655b40187
34+
checksum/config: 694025094891807930f62008e82432b8df8d0d6f867c53510b85f3b57e669df9
3535
spec:
3636
serviceAccountName: default-splunk-otel-collector
3737
nodeSelector:

0 commit comments

Comments
 (0)