Defaults moved to the interface

Author: robsunday

profiler/src/main/java/com/splunk/opentelemetry/profiler/snapshot/SnapshotProfilingConfiguration.java

@@ -29,6 +29,10 @@
 public interface SnapshotProfilingConfiguration {
   double MAX_SELECTION_PROBABILITY = 1.0;
   double DEFAULT_SELECTION_PROBABILITY = 0.01;
+  int DEFAULT_STACK_DEPTH = 1024;
+  long DEFAULT_SAMPLING_INTERVAL = 10;
+  long DEFAULT_EXPORT_INTERVAL = 5000;
+  int DEFAULT_STAGING_CAPACITY = 2000;
 
   void log();
 

profiler/src/main/java/com/splunk/opentelemetry/profiler/snapshot/SnapshotProfilingDeclarativeConfiguration.java

@@ -27,11 +27,6 @@ public class SnapshotProfilingDeclarativeConfiguration implements SnapshotProfil
       Logger.getLogger(SnapshotProfilingDeclarativeConfiguration.class.getName());
   private final DeclarativeConfigProperties profilingConfig;
 
-  private static final int DEFAULT_STACK_DEPTH = 1024;
-  private static final long DEFAULT_SAMPLING_INTERVAL = 10;
-  private static final long DEFAULT_EXPORT_INTERVAL = 5000;
-  private static final int DEFAULT_STAGING_CAPACITY = 2000;
-
   private static final String ROOT_NODE_NAME = "callgraphs";
 
   SnapshotProfilingDeclarativeConfiguration(DeclarativeConfigProperties profilingConfig) {

profiler/src/main/java/com/splunk/opentelemetry/profiler/snapshot/SnapshotProfilingEnvVarsConfiguration.java

@@ -34,11 +34,6 @@ class SnapshotProfilingEnvVarsConfiguration implements SnapshotProfilingConfigur
   static final String EXPORT_INTERVAL_KEY = "splunk.snapshot.profiler.export.interval";
   static final String STAGING_CAPACITY_KEY = "splunk.snapshot.profiler.staging.capacity";
 
-  private static final int DEFAULT_STACK_DEPTH = 1024;
-  private static final Duration DEFAULT_SAMPLING_INTERVAL = Duration.ofMillis(10);
-  private static final Duration DEFAULT_EXPORT_INTERVAL = Duration.ofSeconds(5);
-  private static final int DEFAULT_STAGING_CAPACITY = 2000;
-
   SnapshotProfilingEnvVarsConfiguration(ConfigProperties properties) {
     this.properties = properties;
   }
@@ -89,12 +84,13 @@ public int getStackDepth() {
 
   @Override
   public Duration getSamplingInterval() {
-    return properties.getDuration(SAMPLING_INTERVAL_KEY, DEFAULT_SAMPLING_INTERVAL);
+    return properties.getDuration(
+        SAMPLING_INTERVAL_KEY, Duration.ofMillis(DEFAULT_SAMPLING_INTERVAL));
   }
 
   @Override
   public Duration getExportInterval() {
-    return properties.getDuration(EXPORT_INTERVAL_KEY, DEFAULT_EXPORT_INTERVAL);
+    return properties.getDuration(EXPORT_INTERVAL_KEY, Duration.ofMillis(DEFAULT_EXPORT_INTERVAL));
   }
 
   @Override