Skip to content

Commit 89b8e50

Browse files
committed
TraceRegistry instance sharing between customizer and component provider
1 parent ad9454e commit 89b8e50

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

profiler/src/main/java/com/splunk/opentelemetry/profiler/snapshot/SnapshotProfilingConfigurationCustomizerProvider.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
import java.time.Duration;
3131
import java.util.function.Function;
3232

33-
/** This class combines declarative config compatible port of: - SnapshotProfilingSdkCustomizer */
3433
@AutoService(DeclarativeConfigurationCustomizerProvider.class)
3534
public class SnapshotProfilingConfigurationCustomizerProvider
3635
implements DeclarativeConfigurationCustomizerProvider {
@@ -39,7 +38,10 @@ public class SnapshotProfilingConfigurationCustomizerProvider
3938
private final ContextStorageWrapper contextStorageWrapper;
4039

4140
public SnapshotProfilingConfigurationCustomizerProvider() {
42-
this(new TraceRegistry(), stackTraceSamplerProvider(), new ContextStorageWrapper());
41+
this(
42+
TraceRegistryHolder.getTraceRegistry(),
43+
stackTraceSamplerProvider(),
44+
new ContextStorageWrapper());
4345
}
4446

4547
public void customize(DeclarativeConfigurationCustomizer configurationCustomizer) {

profiler/src/main/java/com/splunk/opentelemetry/profiler/snapshot/SnapshotProfilingSdkCustomizer.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,10 @@ public class SnapshotProfilingSdkCustomizer implements AutoConfigurationCustomiz
3737
private final ContextStorageWrapper contextStorageWrapper;
3838

3939
public SnapshotProfilingSdkCustomizer() {
40-
this(new TraceRegistry(), stackTraceSamplerProvider(), new ContextStorageWrapper());
40+
this(
41+
TraceRegistryHolder.getTraceRegistry(),
42+
stackTraceSamplerProvider(),
43+
new ContextStorageWrapper());
4144
}
4245

4346
private static Function<ConfigProperties, StackTraceSampler> stackTraceSamplerProvider() {

profiler/src/main/java/com/splunk/opentelemetry/profiler/snapshot/SnapshotProfilingSpanProcessorComponentProvider.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,8 @@
2121
import io.opentelemetry.sdk.autoconfigure.spi.internal.ComponentProvider;
2222
import io.opentelemetry.sdk.trace.SpanProcessor;
2323

24-
@SuppressWarnings("rawtypes")
2524
@AutoService(ComponentProvider.class)
26-
public class SnapshotProfilingSpanProcessorComponentProvider
27-
implements ComponentProvider<SpanProcessor> {
25+
public class SnapshotProfilingSpanProcessorComponentProvider implements ComponentProvider {
2826
private final TraceRegistry traceRegistry;
2927

3028
public SnapshotProfilingSpanProcessorComponentProvider() {

0 commit comments

Comments
 (0)