Skip to content

Commit a14b88c

Browse files
committed
Update otel sdk to 1.58.0
1 parent cfef230 commit a14b88c

File tree

6 files changed

+31
-13
lines changed

6 files changed

+31
-13
lines changed

custom/src/main/java/com/splunk/opentelemetry/appd/AppdBonusConfigurationCustomizerProvider.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import com.google.auto.service.AutoService;
2222
import io.opentelemetry.sdk.extension.incubator.fileconfig.DeclarativeConfigurationCustomizer;
2323
import io.opentelemetry.sdk.extension.incubator.fileconfig.DeclarativeConfigurationCustomizerProvider;
24+
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.ExperimentalLanguageSpecificInstrumentationPropertyModel;
2425
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.OpenTelemetryConfigurationModel;
2526
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.PropagatorModel;
2627
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.SpanProcessorModel;
@@ -61,7 +62,7 @@ private static boolean isFeatureEnabled(OpenTelemetryConfigurationModel model) {
6162
return false;
6263
}
6364

64-
Map<String, Object> properties =
65+
Map<String, ExperimentalLanguageSpecificInstrumentationPropertyModel> properties =
6566
model.getInstrumentationDevelopment().getJava().getAdditionalProperties();
6667

6768
return getAdditionalPropertyOrDefault(properties, CONFIG_CISCO_CTX_ENABLED, false);

custom/src/main/java/io/opentelemetry/sdk/autoconfigure/AdditionalPropertiesUtil.java

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
package io.opentelemetry.sdk.autoconfigure;
1818

19+
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.ExperimentalLanguageSpecificInstrumentationPropertyModel;
1920
import java.util.LinkedHashMap;
2021
import java.util.Map;
2122
import java.util.function.BiConsumer;
@@ -24,7 +25,8 @@
2425
@SuppressWarnings("unchecked")
2526
public class AdditionalPropertiesUtil {
2627
public static Object getAdditionalProperty(
27-
Map<String, Object> additionalProperties, String propertyName) {
28+
Map<String, ExperimentalLanguageSpecificInstrumentationPropertyModel> additionalProperties,
29+
String propertyName) {
2830
String[] propertyNameSegments = propertyName.trim().split("\\.");
2931
if (propertyNameSegments.length == 0) {
3032
throw new IllegalArgumentException("Empty property name");
@@ -52,13 +54,17 @@ public static Object getAdditionalProperty(
5254
}
5355

5456
public static Object getAdditionalPropertyOrDefault(
55-
Map<String, Object> additionalProperties, String propertyName, Object defaultValue) {
57+
Map<String, ExperimentalLanguageSpecificInstrumentationPropertyModel> additionalProperties,
58+
String propertyName,
59+
Object defaultValue) {
5660
Object value = getAdditionalProperty(additionalProperties, propertyName);
5761
return value == null ? defaultValue : value;
5862
}
5963

6064
public static Boolean getAdditionalPropertyOrDefault(
61-
Map<String, Object> additionalProperties, String propertyName, boolean defaultValue) {
65+
Map<String, ExperimentalLanguageSpecificInstrumentationPropertyModel> additionalProperties,
66+
String propertyName,
67+
boolean defaultValue) {
6268
Object value = getAdditionalProperty(additionalProperties, propertyName);
6369
if (value instanceof Boolean) {
6470
return (Boolean) value;

custom/src/main/java/io/opentelemetry/sdk/autoconfigure/AutoConfigureUtil.java

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@
1818

1919
import static io.opentelemetry.api.incubator.config.DeclarativeConfigProperties.empty;
2020

21+
import io.opentelemetry.api.OpenTelemetry;
22+
import io.opentelemetry.api.incubator.ExtendedOpenTelemetry;
2123
import io.opentelemetry.api.incubator.config.ConfigProvider;
2224
import io.opentelemetry.api.incubator.config.DeclarativeConfigProperties;
2325
import io.opentelemetry.instrumentation.config.bridge.ConfigPropertiesBackedConfigProvider;
@@ -47,13 +49,22 @@ public static ConfigProperties getConfig(AutoConfiguredOpenTelemetrySdk sdk) {
4749
}
4850

4951
public static boolean isDeclarativeConfig(AutoConfiguredOpenTelemetrySdk sdk) {
50-
return !(sdk.getConfigProvider() instanceof ConfigPropertiesBackedConfigProvider);
52+
OpenTelemetry openTelemetry = sdk.getOpenTelemetrySdk();
53+
if (openTelemetry instanceof ExtendedOpenTelemetry) {
54+
return !(((ExtendedOpenTelemetry) openTelemetry).getConfigProvider()
55+
instanceof ConfigPropertiesBackedConfigProvider);
56+
}
57+
return false;
5158
}
5259

5360
@Nullable
5461
public static DeclarativeConfigProperties getDistributionConfig(
5562
AutoConfiguredOpenTelemetrySdk sdk) {
56-
ConfigProvider configProvider = (ConfigProvider) sdk.getConfigProvider();
63+
OpenTelemetry openTelemetry = sdk.getOpenTelemetrySdk();
64+
if (!(openTelemetry instanceof ExtendedOpenTelemetry)) {
65+
return null;
66+
}
67+
ConfigProvider configProvider = ((ExtendedOpenTelemetry) openTelemetry).getConfigProvider();
5768
if (configProvider == null) {
5869
return null;
5970
}

dependencyManagement/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ plugins {
22
`java-platform`
33
}
44

5-
val otelVersion = "1.57.0"
5+
val otelVersion = "1.58.0"
66
val otelAlphaVersion = otelVersion.replaceFirst("(-SNAPSHOT)?$".toRegex(), "-alpha$1")
77
val otelInstrumentationVersion = "2.24.0-SNAPSHOT"
88
val otelInstrumentationAlphaVersion = otelInstrumentationVersion.replaceFirst("(-SNAPSHOT)?$".toRegex(), "-alpha$1")

testing/common/src/main/java/com/splunk/opentelemetry/testing/declarativeconfig/DeclarativeConfigTestUtil.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@
1616

1717
package com.splunk.opentelemetry.testing.declarativeconfig;
1818

19+
import io.opentelemetry.api.incubator.ExtendedOpenTelemetry;
1920
import io.opentelemetry.api.incubator.config.ConfigProvider;
2021
import io.opentelemetry.instrumentation.config.bridge.DeclarativeConfigPropertiesBridgeBuilder;
2122
import io.opentelemetry.sdk.OpenTelemetrySdk;
2223
import io.opentelemetry.sdk.autoconfigure.AutoConfiguredOpenTelemetrySdk;
2324
import io.opentelemetry.sdk.autoconfigure.SdkAutoconfigureAccess;
24-
import io.opentelemetry.sdk.autoconfigure.internal.AutoConfigureUtil;
2525
import io.opentelemetry.sdk.extension.incubator.fileconfig.DeclarativeConfiguration;
2626
import io.opentelemetry.sdk.extension.incubator.fileconfig.DeclarativeConfigurationBuilder;
2727
import io.opentelemetry.sdk.extension.incubator.fileconfig.DeclarativeConfigurationCustomizerProvider;
@@ -79,16 +79,16 @@ public static AutoConfiguredOpenTelemetrySdk createAutoConfiguredSdk(String yaml
7979
"otel.experimental.config.file", configFilePath.toString()))
8080
.build();
8181

82-
ConfigProvider configProvider = AutoConfigureUtil.getConfigProvider(autoConfiguredSdk);
82+
ConfigProvider configProvider =
83+
((ExtendedOpenTelemetry) autoConfiguredSdk.getOpenTelemetrySdk()).getConfigProvider();
8384
OpenTelemetrySdk sdk = autoConfiguredSdk.getOpenTelemetrySdk();
8485

8586
if (configProvider != null) {
8687
return SdkAutoconfigureAccess.create(
8788
sdk,
8889
SdkAutoconfigureAccess.getResource(autoConfiguredSdk),
8990
new DeclarativeConfigPropertiesBridgeBuilder()
90-
.buildFromInstrumentationConfig(configProvider.getInstrumentationConfig()),
91-
configProvider);
91+
.buildFromInstrumentationConfig(configProvider.getInstrumentationConfig()));
9292
}
9393

9494
return autoConfiguredSdk;

testing/common/src/main/java/io/opentelemetry/sdk/autoconfigure/SdkAutoconfigureAccess.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public static Resource getResource(AutoConfiguredOpenTelemetrySdk sdk) {
2929
}
3030

3131
public static AutoConfiguredOpenTelemetrySdk create(
32-
OpenTelemetrySdk sdk, Resource resource, ConfigProperties config, Object configProvider) {
33-
return AutoConfiguredOpenTelemetrySdk.create(sdk, resource, config, configProvider);
32+
OpenTelemetrySdk sdk, Resource resource, ConfigProperties config) {
33+
return AutoConfiguredOpenTelemetrySdk.create(sdk, resource, config);
3434
}
3535
}

0 commit comments

Comments
 (0)