feat: Remove twitter features

Author: romainricard

.pylintrc

@@ -14,6 +14,7 @@ disable=
     too-many-locals,
     too-many-branches, # FIXME remove when possible
     fixme,
+    too-many-positional-arguments,
     duplicate-code, # FIXME remove when apiv1 is retired
 
 load-plugins=pylint_django

requirements.txt

@@ -18,7 +18,6 @@ httpx==0.24.1; python_version >= '3.7'
 idna==3.6; python_version >= '3.5'
 markdown-it-py==3.0.0; python_version >= '3.8'
 mdurl==0.1.2; python_version >= '3.7'
-oauthlib==3.2.2; python_version >= '3.6'
 pbr==6.0.0; python_version >= '2.6'
 pillow==10.3.0
 protobuf==3.20.3; python_version >= '3.7'
@@ -29,12 +28,10 @@ pydantic-core==2.16.3; python_version >= '3.8'
 pygments==2.17.2; python_version >= '3.7'
 pyyaml==6.0.1
 requests==2.31.0
-requests-oauthlib==1.3.1; python_version >= '2.7' and python_version not in '3.0, 3.1, 3.2, 3.3'
 rich==13.7.1; python_full_version >= '3.7.0'
 signalstickers-client==3.3.0
 sniffio==1.3.1; python_version >= '3.7'
 sqlparse==0.4.4; python_version >= '3.5'
 stevedore==5.2.0; python_version >= '3.8'
-tweepy==4.16.0
 typing-extensions==4.11.0; python_version >= '3.8'
 urllib3==2.2.1; python_version >= '3.8'

signalstickers/api/tests.py

@@ -463,7 +463,7 @@ def test_get_all_packs(self, mocked_getpacklib):
 
         # Second pack, status ONLINE: should be returned second by the API
         mocked_getpacklib.return_value = TestPack(
-            "Pack title 2", "Pack author 2", b"\x61\x63\x54\x4C"
+            "Pack title 2", "Pack author 2", b"\x61\x63\x54\x4c"
         )
 
         Pack.objects.new(

signalstickers/api/views/contribution_view.py

@@ -84,7 +84,7 @@ def put(self, request):
                     submitter_comments=req_srl.validated_data.get(
                         "submitter_comments", ""
                     ),
-                    api_via=api_via,
+                    api_via=api_via,  # pylint: disable=possibly-used-before-assignment
                 )
             except ValidationError as val_err:
                 raise ApiException(str(val_err)) from None

signalstickers/api_v2/test/test_packs.py

@@ -37,7 +37,7 @@ def test_get_all_packs(self, mocked_getpacklib):
 
         # Second pack, status ONLINE: should be returned second by the API
         mocked_getpacklib.return_value = TestPack(
-            "Pack title 2", "Pack author 2", b"\x61\x63\x54\x4C"
+            "Pack title 2", "Pack author 2", b"\x61\x63\x54\x4c"
         )
 
         Pack.objects.new(

signalstickers/core/admin/pack_admin.py

@@ -70,7 +70,7 @@ def _view(self, obj):
         ("Animation", {"fields": ("animated_detected", "animated_mode", "animated")}),
         (
             "Review",
-            {"fields": ("submitter_comments", "status", "status_comments", "tweeted")},
+            {"fields": ("submitter_comments", "status", "status_comments")},
         ),
     )
     autocomplete_fields = ("tags",)
@@ -107,7 +107,6 @@ def get_form(self, request, obj=None, **kwargs):  # pylint: disable=arguments-di
                     "animated": "This is the final animated status that will be displayed to users.",
                     "submitter_comments": "Users can leave comments when the submit a pack.",
                     "status_comments": "If needed, explain here why the pack has been refused, or almost refused.",
-                    "tweeted": "If this checkbox is checked and you uncheck it, the pack will be tweeted again. If the pack is new, check this box to prevent it from being tweeted.",
                 }
             }
         )

signalstickers/core/management/commands/export_packs_img.py

@@ -19,9 +19,9 @@ def handle(self, *args, **options):
 
                 img = sticker.image_data
                 sticker_id = int(sticker.id)
-                if b"\x61\x63\x54\x4C" in img:  # APNG acTL chunk
+                if b"\x61\x63\x54\x4c" in img:  # APNG acTL chunk
                     ext = "png"
-                elif img.startswith(b"\x89\x50\x4E\x47\x0D\x0A\x1A\x0A"):  # PNG
+                elif img.startswith(b"\x89\x50\x4e\x47\x0d\x0a\x1a\x0a"):  # PNG
                     ext = "png"
                 elif img.startswith(b"\x47\x49\x46\x38\x39\x61"):
                     ext = "gif"
@@ -32,6 +32,7 @@ def handle(self, *args, **options):
                     ext = "webp"
                 else:
                     print("Unknown file type")
+                    ext = ""
 
                 nb_exported += 1
 

signalstickers/core/management/commands/import_from_twitter.py

@@ -31,7 +31,6 @@ def handle(self, *args, **options):
                     nsfw=pack_data.get("nsfw", False),
                     original=pack_data.get("original", False),
                     tags=tags,
-                    tweeted=True,
                     editorschoice=data.get("editorschoice", False),
                 )