Skip to content

Commit 4fdfdd9

Browse files
committed
fix: use mousemove to focus suggestion
1 parent ad43016 commit 4fdfdd9

File tree

6 files changed

+1487
-1381
lines changed

6 files changed

+1487
-1381
lines changed

.changeset/dry-phones-explode.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"react-mentions": minor
3+
---
4+
5+
Focus suggestions on mouse move instead of mouse enter

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-mentions",
3-
"version": "4.4.7",
3+
"version": "4.5.7",
44
"description": "React mentions input",
55
"main": "dist/react-mentions.cjs.js",
66
"module": "dist/react-mentions.esm.js",

src/MentionsInput.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,7 @@ class MentionsInput extends React.Component {
281281
customSuggestionsContainer ={this.props.customSuggestionsContainer}
282282
onSelect={this.addMention}
283283
onMouseDown={this.handleSuggestionsMouseDown}
284-
onMouseEnter={this.handleSuggestionsMouseEnter}
284+
onMouseMove={this.handleSuggestionsMouseMove}
285285
isLoading={this.isLoading()}
286286
isOpened={this.isOpened()}
287287
ignoreAccents={this.props.ignoreAccents}
@@ -678,7 +678,7 @@ class MentionsInput extends React.Component {
678678
this._suggestionsMouseDown = true
679679
}
680680

681-
handleSuggestionsMouseEnter = (focusIndex) => {
681+
handleSuggestionsMouseMove = (focusIndex) => {
682682
this.setState({
683683
focusIndex,
684684
scrollFocusedIntoView: false,

src/Suggestion.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,15 @@ function Suggestion({
99
ignoreAccents,
1010
index,
1111
onClick,
12-
onMouseEnter,
12+
onMouseMove,
1313
query,
1414
renderSuggestion,
1515
suggestion,
1616
style,
1717
className,
1818
classNames,
1919
}) {
20-
const rest = { onClick, onMouseEnter }
20+
const rest = { onClick, onMouseMove }
2121

2222
const renderContent = () => {
2323
let display = getDisplay()

src/SuggestionsOverlay.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ function SuggestionsOverlay({
2626
style,
2727
customSuggestionsContainer,
2828
onMouseDown,
29-
onMouseEnter,
29+
onMouseMove,
3030
}) {
3131
const [ulElement, setUlElement] = useState()
3232

@@ -85,7 +85,7 @@ function SuggestionsOverlay({
8585
suggestion={result}
8686
focused={isFocused}
8787
onClick={() => select(result, queryInfo)}
88-
onMouseEnter={() => handleMouseEnter(index)}
88+
onMouseMove={() => handleMouseMove(index)}
8989
/>
9090
)
9191
}
@@ -98,9 +98,9 @@ function SuggestionsOverlay({
9898
return <LoadingIndicator style={style('loadingIndicator')} />
9999
}
100100

101-
const handleMouseEnter = (index, ev) => {
102-
if (onMouseEnter) {
103-
onMouseEnter(index)
101+
const handleMouseMove = (index, ev) => {
102+
if (onMouseMove) {
103+
onMouseMove(index)
104104
}
105105
}
106106

0 commit comments

Comments
 (0)