chore: skip updating attester and sync voting assignments if error from the poll channels

Author: shane-moore

anchor/validator_store/src/lib.rs

@@ -303,7 +303,7 @@ impl<T: SlotClock, E: EthSpec> AnchorValidatorStore<T, E> {
         // Determine the appropriate version based on block type
         let block_version = block.fork_name_unchecked().into();
 
-        // Create the validator voting assignmentsrmation
+        // Create the validator duty information
         let validator_duty = ValidatorDuty {
             r#type: BEACON_ROLE_PROPOSER,
             pub_key: validator.public_key,
@@ -750,7 +750,7 @@ struct VotingContext {
     beacon_vote: BeaconVote,
 }
 
-/// Cached validator voting assignmentsrmation for a slot.
+/// Cached validator voting assignments for a slot.
 ///
 /// This struct caches voting assignments computed at slot start and reuses it at 1/3 slot,
 /// eliminating redundant computation. It supports two different counting patterns:

anchor/validator_store/src/metadata_service.rs

@@ -90,8 +90,16 @@ impl<E: EthSpec, T: SlotClock + 'static> MetadataService<E, T> {
 
                         // Wait for BOTH DutiesService polls to complete for this slot.
                         // This guarantees duties are cached before we read them.
-                        let _ = attesters_poll_rx.wait_for(|&s| s >= slot).await;
-                        let _ = sync_poll_rx.wait_for(|&s| s >= slot).await;
+                        // If poll channels are closed, skip this slot to avoid signing with stale
+                        // data.
+                        if attesters_poll_rx.wait_for(|&s| s >= slot).await.is_err() {
+                            error!(%slot, "Attesters poll channel closed, skipping slot");
+                            continue;
+                        }
+                        if sync_poll_rx.wait_for(|&s| s >= slot).await.is_err() {
+                            error!(%slot, "Sync poll channel closed, skipping slot");
+                            continue;
+                        }
 
                         if let Err(err) = self_clone_phase1.update_voting_assignments() {
                             error!(err, "Failed to update validator voting assignments");