Skip to content

Commit e3b84e7

Browse files
committed
review 2
1 parent 9530d77 commit e3b84e7

File tree

4 files changed

+15
-13
lines changed

4 files changed

+15
-13
lines changed

Diff for: Cargo.lock

-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: anchor/http_api/src/router.rs

+7
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ pub fn new() -> Router {
99
Router::new()
1010
.route("/", get(root))
1111
.route("/anchor/version", get(get_version))
12+
.route("/anchor/peers", get(get_peers))
1213
}
1314

1415
// Temporary return value.
@@ -21,3 +22,9 @@ async fn get_version() -> Json<GenericResponse<VersionData>> {
2122
version: version_with_platform(),
2223
}))
2324
}
25+
26+
async fn get_peers() -> Json<GenericResponse<VersionData>> {
27+
Json(GenericResponse::from(VersionData {
28+
version: version_with_platform(),
29+
}))
30+
}

Diff for: anchor/logging/Cargo.toml

-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ chrono = { version = "0.4", default-features = false, features = [
1010
"std",
1111
] }
1212
logroller = "0.1.8"
13-
serde = { workspace = true }
1413
tracing = { workspace = true }
1514
tracing-appender = "0.2"
1615
tracing-core = "0.1"

Diff for: anchor/logging/src/logging.rs

+8-11
Original file line numberDiff line numberDiff line change
@@ -2,18 +2,20 @@
22
use std::path::PathBuf;
33

44
use logroller::{Compression, LogRollerBuilder, Rotation, RotationSize};
5-
use serde::{Deserialize, Serialize};
65
use tracing::Level;
76
use tracing_appender::non_blocking::{NonBlocking, WorkerGuard};
87

98
pub use crate::tracing_libp2p_discv5_layer::{
109
create_libp2p_discv5_tracing_layer, Libp2pDiscv5TracingLayer,
1110
};
1211

13-
#[derive(Debug, Clone, Serialize, Deserialize)]
12+
const MAX_LOG_SIZE: u64 = 20;
13+
const MAX_LOG_NUMBER: usize = 5;
14+
const DEFAULT_DEBUG_LEVEL: Level = Level::INFO;
15+
16+
#[derive(Clone)]
1417
pub struct LoggerConfig {
1518
pub path: Option<PathBuf>,
16-
#[serde(skip_serializing, skip_deserializing, default = "default_debug_level")]
1719
pub debug_level: Level,
1820
pub max_log_size: u64,
1921
pub max_log_number: usize,
@@ -23,18 +25,13 @@ impl Default for LoggerConfig {
2325
fn default() -> Self {
2426
LoggerConfig {
2527
path: None,
26-
debug_level: Level::INFO,
27-
max_log_size: 20,
28-
max_log_number: 5,
28+
debug_level: DEFAULT_DEBUG_LEVEL,
29+
max_log_size: MAX_LOG_SIZE,
30+
max_log_number: MAX_LOG_NUMBER,
2931
compression: false,
3032
}
3133
}
3234
}
33-
34-
fn default_debug_level() -> Level {
35-
Level::INFO
36-
}
37-
3835
pub struct LoggingLayer {
3936
pub non_blocking_writer: NonBlocking,
4037
pub guard: WorkerGuard,

0 commit comments

Comments
 (0)