Skip to content

Commit 8c2b63a

Browse files
committed
Fix lints
1 parent 1ef6104 commit 8c2b63a

File tree

5 files changed

+14
-3
lines changed

5 files changed

+14
-3
lines changed

beacon_node/beacon_chain/src/fetch_blobs/fetch_blobs_beacon_adapter.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
use crate::fetch_blobs::{EngineGetBlobsOutput, FetchEngineBlobError};
2-
use crate::observed_block_producers::ProposalKey;
32
use crate::{AvailabilityProcessingStatus, BeaconChain, BeaconChainTypes};
43
use execution_layer::json_structures::{BlobAndProofV1, BlobAndProofV2};
54
use kzg::Kzg;

beacon_node/beacon_chain/tests/events.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
use beacon_chain::blob_verification::GossipVerifiedBlob;
12
use beacon_chain::data_column_verification::GossipVerifiedDataColumn;
23
use beacon_chain::test_utils::{
34
BeaconChainHarness, fork_name_from_env, generate_data_column_sidecars_from_block, test_spec,

beacon_node/http_api/src/publish_blocks.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -515,7 +515,7 @@ fn publish_column_sidecars<T: BeaconChainTypes>(
515515
data_column_sidecars.shuffle(&mut **chain.rng.lock());
516516
let dropped_indices = data_column_sidecars
517517
.drain(columns_to_keep..)
518-
.map(|d| d.index)
518+
.map(|d| *d.index())
519519
.collect::<Vec<_>>();
520520
debug!(indices = ?dropped_indices, "Dropping data columns from publishing");
521521
}

beacon_node/network/src/network_beacon_processor/gossip_methods.rs

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -667,6 +667,15 @@ impl<T: BeaconChainTypes> NetworkBeaconProcessor<T> {
667667
}
668668
Err(err) => {
669669
match err {
670+
GossipDataColumnError::InvalidVariant => {
671+
// TODO(gloas) we should probably penalize the peer here
672+
debug!(
673+
%slot,
674+
%block_root,
675+
%index,
676+
"Invalid gossip data column variant."
677+
)
678+
}
670679
GossipDataColumnError::PriorKnownUnpublished => {
671680
debug!(
672681
%slot,

beacon_node/network/src/sync/manager.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -889,7 +889,9 @@ impl<T: BeaconChainTypes> SyncManager<T> {
889889
);
890890
}
891891
// TODO(gloas) support gloas data column variant
892-
DataColumnSidecar::Gloas(_) => Err(GossipDataColumnError::InvalidVariant),
892+
DataColumnSidecar::Gloas(_) => {
893+
error!("Gloas variant not yet supported")
894+
}
893895
}
894896
}
895897
SyncMessage::UnknownBlockHashFromAttestation(peer_id, block_root) => {

0 commit comments

Comments
 (0)