Skip to content

Commit ac8d773

Browse files
authored
Fix Makefile to avoid git describe error in CI (#8513)
Fixes the error `fatal: No names found, cannot describe anything.` that occurs when running `make` commands in CI (GitHub Actions). https://github.com/sigp/lighthouse/actions/runs/19839541042/job/56844781126#step:5:13 > fatal: No names found, cannot describe anything. Changed the `GIT_TAG` variable assignment in the Makefile from immediate evaluation to lazy evaluation: ```diff - GIT_TAG := $(shell git describe --tags --candidates 1) + GIT_TAG = $(shell git describe --tags --candidates 1) ``` This change ensures that git describe is only executed when `GIT_TAG` is actually used (in the `build-release-tarballs` target), rather than on every Makefile invocation. Co-Authored-By: ackintosh <sora.akatsuki@gmail.com>
1 parent 32f7615 commit ac8d773

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
EF_TESTS = "testing/ef_tests"
44
STATE_TRANSITION_VECTORS = "testing/state_transition_vectors"
55
EXECUTION_ENGINE_INTEGRATION = "testing/execution_engine_integration"
6-
GIT_TAG := $(shell git describe --tags --candidates 1)
6+
GIT_TAG = $(shell git describe --tags --candidates 1)
77
BIN_DIR = "bin"
88

99
X86_64_TAG = "x86_64-unknown-linux-gnu"

0 commit comments

Comments
 (0)