Apply review suggestions

Author: uvizhe

.github/workflows/test-suite.yml

@@ -329,7 +329,7 @@ jobs:
       run: make cargo-fmt
     - name: Lint code for quality and style with Clippy
       run: make lint-full
-    - name: Check dependencies for usage of an unencrypted HTTP
+    - name: Check dependencies for unencrypted HTTP links
       run: make insecure-deps
     - name: Certify Cargo.lock freshness
       run: git diff --exit-code Cargo.lock

Cargo.toml

@@ -274,7 +274,7 @@ validator_test_rig = { path = "testing/validator_test_rig" }
 warp = { version = "0.3.7", default-features = false, features = ["tls"] }
 warp_utils = { path = "common/warp_utils" }
 workspace_members = { path = "common/workspace_members" }
-xdelta3 = { git = "http://github.com/sigp/xdelta3-rs", rev = "4db64086bb02e9febb584ba93b9d16bb2ae3825a" }
+xdelta3 = { git = "https://github.com/sigp/xdelta3-rs", rev = "4db64086bb02e9febb584ba93b9d16bb2ae3825a" }
 zeroize = { version = "1", features = ["zeroize_derive", "serde"] }
 zip = "0.6"
 zstd = "0.13"

Makefile

@@ -343,14 +343,15 @@ vendor:
 udeps:
 	cargo +$(PINNED_NIGHTLY) udeps --tests --all-targets --release --features "$(TEST_FEATURES)"
 
-# Checks dependencies for usage of an unencrypted HTTP
+# Checks dependencies for unencrypted HTTP links
 # Tee preserves output. If there are matches, print a message and return 1
 insecure-deps:
 	bash -c \
 	  "find -name Cargo.toml \
 			| xargs grep -P \"git\s?=\s?[\\\"']http:\" \
 			| tee /dev/tty \
-			| [ \`wc -l\` == 0 ] || (echo \"Using plain HTTP in dependencies is forbidden\" && false)"
+			| [ \`wc -l\` == 0 ] && echo \"All Git dependencies use secure HTTPS\" \
+			  || (echo \"Using plain HTTP in dependencies is forbidden\" && false)"
 
 # Performs a `cargo` clean and cleans the `ef_tests` directory.
 clean: