Added Tests

Author: Patchoulis

beacon_node/lighthouse_network/src/peer_manager/peerdb.rs

@@ -1917,6 +1917,66 @@ mod tests {
         p
     }
 
+    #[test]
+    fn test_add_penalty_record() {
+        let mut pdb = get_db();
+        let random_peer = PeerId::random();
+
+        pdb.connect_ingoing(&random_peer, "/ip4/0.0.0.0".parse().unwrap(), None);
+
+        // Check to see if get_penalty_records is able to get the associated peer info
+        assert!(pdb.get_penalty_records(&random_peer).is_some());
+
+        // Check to see if there are no initial penalty records
+        assert_eq!(pdb.get_penalty_records(&random_peer).unwrap().into_iter().count(),0);
+        
+        let _ = pdb.report_peer(
+            &random_peer,
+            PeerAction::HighToleranceError,
+            ReportSource::PeerManager,
+            "Minor report action",
+        );
+
+        // Check to see if there was a penalty record added
+        assert_eq!(pdb.get_penalty_records(&random_peer).unwrap().into_iter().count(),1);
+
+        let first_record = pdb.get_penalty_records(&random_peer).unwrap().into_iter().next().unwrap();
+
+        // Check to see the correct report action for the penalty record
+        assert!(matches!(first_record.action(),PeerAction::HighToleranceError));
+
+        // Check to see the correct report source for the penalty record
+        assert!(matches!(first_record.source(),ReportSource::PeerManager));
+
+        // Check to see the correct message for the penalty record
+        assert_eq!(*first_record.msg(),"Minor report action".to_string());
+
+        // Check to see the correct result for the penalty record
+        assert!(matches!(first_record.result(),ScoreUpdateResult::NoAction));
+
+        let _ = pdb.report_peer(
+            &random_peer,
+            PeerAction::HighToleranceError,
+            ReportSource::PeerManager,
+            "Minor report action",
+        );
+
+        // Check to see if there was a penalty record added
+        assert_eq!(pdb.get_penalty_records(&random_peer).unwrap().into_iter().count(),2);
+
+        for _ in 1..(MAX_STORED_PENALTY_RECORDS+1) {
+            let _ = pdb.report_peer(
+                &random_peer,
+                PeerAction::HighToleranceError,
+                ReportSource::PeerManager,
+                "Minor report action",
+            );
+        }
+
+        // Check to make sure that the number of penalty records don't exceed the maximum
+        assert_eq!(pdb.get_penalty_records(&random_peer).unwrap().into_iter().count(),MAX_STORED_PENALTY_RECORDS);
+    }
+
     #[test]
     fn test_ban_address() {
         let mut pdb = get_db();

beacon_node/lighthouse_network/src/peer_manager/peerdb/peer_info.rs

@@ -399,6 +399,12 @@ impl<E: EthSpec> PeerInfo<E> {
         }
     }
 
+    /// Gets an iterator with the penalty records
+    // VISIBILITY: The peer manager is able to add a penalty record
+    pub(in crate::peer_manager) fn get_penalty_records(&self) -> impl Iterator<Item = &PenaltyRecord>{
+        self.penalty_records.iter()
+    }
+
     /// Sets the connection status of the peer.
     pub(super) fn set_connection_status(&mut self, connection_status: PeerConnectionStatus) {
         self.connection_status = connection_status

beacon_node/lighthouse_network/src/peer_manager/peerdb/score.rs

@@ -70,6 +70,31 @@ impl PenaltyRecord {
             time_stamp: time_stamp
         }
     }
+
+    /// Obtains the action from the penalty record
+    pub fn action(&self) -> &PeerAction {
+        &self.action
+    }
+
+    /// Obtains the report source from the penalty record
+    pub fn source(&self) -> &ReportSource {
+        &self.source
+    }
+
+    /// Obtains the message associated with the penalty record
+    pub fn msg(&self) -> &String {
+        &self.msg
+    }
+
+    /// Obtains the result of the penalty record
+    pub fn result(&self) -> &ScoreUpdateResult {
+        &self.result
+    }
+
+    /// Obtains the time stamp of when the penalty record was made
+    pub fn time_stamp(&self) -> &Option<u128> {
+        &self.time_stamp
+    }
 }
 
 /// A collection of actions a peer can perform which will adjust its score.