Skip to content

Refactor validator monitor missed block tests #6293

Open
@michaelsproul

Description

@michaelsproul

Description

The validator monitor missed block tests are quite fragile and depend on hardcoded validator indices which break with each hard fork.

We should rewrite these tests to dynamically use correct validator indices.

The tests are also complicated by the "simulation" of missed blocks through the mutatation of the block_roots array. It would be simpler if they just avoided creating blocks at those slots using extend_chain.

Version

Lighthouse v5.3.0

Steps to resolve

Refactor the validator monitor tests, e.g. produces_missed_blocks so they don't use hardcoded validator indices or manual block_roots mutations.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions